External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-24 22:55:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid creating top level cgroups if just querying for existance

Browse Source 
When getting the driver/domain cgroup it is possible to specify
whether it should be auto created. If auto-creation was turned
off, libvirt still mistakenly created its own top level cgroup

* src/util/cgroup.c: Honour autocreate flag for top level cgroup
This commit is contained in:
Daniel P. Berrange 2010-03-04 11:01:52 +00:00
parent 5c0e525c1c
commit ede3bc1128
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/util/cgroup.c
View File

@ -519,7 +519,8 @@ err:
} }
static int virCgroupAppRoot(int privileged, static int virCgroupAppRoot(int privileged,
virCgroupPtr *group) virCgroupPtr *group,
int create)
{ {
virCgroupPtr rootgrp = NULL; virCgroupPtr rootgrp = NULL;
int rc; int rc;
@ -551,7 +552,7 @@ static int virCgroupAppRoot(int privileged,
if (rc != 0) if (rc != 0)
goto cleanup; goto cleanup;
rc = virCgroupMakeGroup(rootgrp, *group, 1); rc = virCgroupMakeGroup(rootgrp, *group, create);
cleanup: cleanup:
virCgroupFree(&rootgrp); virCgroupFree(&rootgrp);
@ -638,7 +639,7 @@ int virCgroupForDriver(const char *name,
char *path = NULL; char *path = NULL;
virCgroupPtr rootgrp = NULL; virCgroupPtr rootgrp = NULL;
rc = virCgroupAppRoot(privileged, &rootgrp); rc = virCgroupAppRoot(privileged, &rootgrp, create);
if (rc != 0) if (rc != 0)
goto out; goto out;