External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

testParseXMLDocFromFile: Validate that the replaced node is identical with parsed root

Browse Source 
When replacing a definition node by contents of a file the root node in
the file must match the replaced node.

Enforce that by passing the original node name as the 'rootnode'
argument of virXMLParse.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2022-09-22 16:41:25 +02:00
parent b46667ac6f
commit ee3b96bcb0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/test/test_driver.c
View File

@ -851,7 +851,8 @@ testParseXMLDocFromFile(xmlNodePtr node,
g_autofree char *absFile = testBuildFilename(file, relFile); g_autofree char *absFile = testBuildFilename(file, relFile);
xmlNodePtr newnode = NULL; xmlNodePtr newnode = NULL;
if (!(doc = virXMLParse(absFile, NULL, NULL, NULL, NULL, NULL, false))) if (!(doc = virXMLParse(absFile, NULL, NULL, (const char *) node->name,
NULL, NULL, false)))
return NULL; return NULL;
if (!(newnode = xmlCopyNode(xmlDocGetRootElement(doc), 1))) { if (!(newnode = xmlCopyNode(xmlDocGetRootElement(doc), 1))) {