rpc: Be more precise in which cases the authentication is needed and introduce *Locked

Be more precise in which cases the authentication is needed and
introduce *Locked.

Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
Reviewed-by: Stefan Zimmermann <stzi@linux.vnet.ibm.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
Marc Hartmayer 2017-12-21 15:29:00 +01:00 committed by John Ferlan
parent 6e7e553180
commit ee8bb0511d
3 changed files with 13 additions and 4 deletions

View File

@ -143,6 +143,7 @@ virNetServerClientIsLocal;
virNetServerClientIsSecure;
virNetServerClientLocalAddrStringSASL;
virNetServerClientNeedAuth;
virNetServerClientNeedAuthLocked;
virNetServerClientNew;
virNetServerClientNewPostExecRestart;
virNetServerClientPreExecRestart;

View File

@ -1518,12 +1518,19 @@ int virNetServerClientSendMessage(virNetServerClientPtr client,
}
bool virNetServerClientNeedAuth(virNetServerClientPtr client)
bool
virNetServerClientNeedAuthLocked(virNetServerClientPtr client)
{
bool need = false;
return !(client->auth == VIR_NET_SERVER_SERVICE_AUTH_NONE);
}
bool
virNetServerClientNeedAuth(virNetServerClientPtr client)
{
bool need;
virObjectLock(client);
if (client->auth)
need = true;
need = virNetServerClientNeedAuthLocked(client);
virObjectUnlock(client);
return need;
}

View File

@ -147,6 +147,7 @@ int virNetServerClientSendMessage(virNetServerClientPtr client,
virNetMessagePtr msg);
bool virNetServerClientNeedAuth(virNetServerClientPtr client);
bool virNetServerClientNeedAuthLocked(virNetServerClientPtr client);
int virNetServerClientGetTransport(virNetServerClientPtr client);
int virNetServerClientGetInfo(virNetServerClientPtr client,