From ef476708f31073c3816a42fe626a33bc405445dd Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 16 Feb 2022 16:26:31 +0100 Subject: [PATCH] virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_FD_PASSING MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The feature implies that fd passing works with RPC. Non-remote impls thus should always report support. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- src/driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/driver.c b/src/driver.c index bcf5db5998..41b4f0055b 100644 --- a/src/driver.c +++ b/src/driver.c @@ -362,10 +362,14 @@ virDriverFeatureIsGlobal(virDrvFeature feat, * thus use the correct ordering with an updated server. All drivers must * signal support for this feature. */ case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: + /* The remote driver intercepts and always reports the feature since it was + * introduced. This means that all driver implementations should advertise + * it too as it works natively without RPC. Always enabling this will also + * prevent regressions when a driver is used in embedded mode */ + case VIR_DRV_FEATURE_FD_PASSING: *supported = 1; return true; - case VIR_DRV_FEATURE_FD_PASSING: case VIR_DRV_FEATURE_MIGRATION_V2: case VIR_DRV_FEATURE_MIGRATION_V3: case VIR_DRV_FEATURE_MIGRATION_P2P: