From ef5f998a96b4b98cfff2b4ddf21a4e0ac9dfd5f6 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Mon, 26 Jul 2021 14:01:15 +0200 Subject: [PATCH] qemu: capabilities: Note that basing probing on 'query-command-line-options' should be avoided MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add a comment that will attempt to discourage adding new capabilities based on 'query-command-line-options'. Signed-off-by: Peter Krempa Reviewed-by: Martin Kletzander Reviewed-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index adb15a89f2..4b303b660d 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3221,6 +3221,10 @@ struct virQEMUCapsCommandLineProps { int flag; }; + +/* This uses 'query-command-line-options' which uses old-style argument parsers + * in qemu and thus isn't being properly extended. Other means to detect + * features should be used if possible. */ static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] = { { "boot-opts", "strict", QEMU_CAPS_BOOT_STRICT }, { "boot-opts", "reboot-timeout", QEMU_CAPS_REBOOT_TIMEOUT },