External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-10 23:07:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

phyp: avoid a logic bug

Browse Source 
Ever since commit ebc46f, the destroy function built two command
variants but only used one.  I went with the variant that matches
the idiom used in the counterpart of phypBuildStoragePool.

* src/phyp/phyp_driver.c (phypDestroyStoragePool): Avoid
clobbering cmd.  Fix error message typo.
This commit is contained in:
Eric Blake 2011-04-14 10:35:42 -06:00
parent dbe3bad987
commit ef6147c40e
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/phyp/phyp_driver.c
View File

@ -2936,19 +2936,10 @@ phypDestroyStoragePool(virStoragePoolPtr pool)
return -1;
}
cmd = virBufferContentAndReset(&buf);
if (virAsprintf(&cmd,
"viosvrcmd -m %s --id %d -c "
"'rmsp %s'", managed_system, vios_id,
pool->name) < 0) {
virReportOOMError();
goto cleanup;
}
ret = phypExec(session, cmd, &exit_status, conn);
if (exit_status < 0) {
VIR_ERROR(_("Unable to create Storage Pool: %s"), ret);
VIR_ERROR(_("Unable to destroy Storage Pool: %s"), ret);
goto cleanup;
}