From f01fc4d1197c8f832638407e96502a23a0725990 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Thu, 23 Jun 2022 14:25:30 +0200 Subject: [PATCH] qemu_migration: Don't set unlimited memlock limit for RDMA MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Our documentation says RDMA migration requires hard_limit to be set so that we know how big memory locking limit should be set for the domain during migration. But since commit v1.2.13-71-gcf521fc8ba (which changed the default hard_limit value from 0 to VIR_DOMAIN_MEMORY_PARAM_UNLIMITED) we were actually setting memlock limit to unlimited if hard_limit was not set. Signed-off-by: Jiri Denemark Reviewed-by: Ján Tomko --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 04903a424f..e4e0417bde 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -3180,7 +3180,7 @@ qemuMigrationDstPrepareActive(virQEMUDriver *driver, } if (STREQ_NULLABLE(protocol, "rdma") && - vm->def->mem.hard_limit > 0 && + virMemoryLimitIsSet(vm->def->mem.hard_limit) && qemuDomainSetMaxMemLock(vm, vm->def->mem.hard_limit << 10, &priv->preMigrationMemlock) < 0) { goto error;