External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-12 07:42:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: agent: remove redundant checks

Browse Source 
virJSONValueObjectGetArray returns NULL if the object with
the supplied key is not an array.

Calling virJSONValueIsArray right after is redundant.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Neal Gompa <ngompa13@gmail.com>
This commit is contained in:
Ján Tomko 2020-10-05 22:09:49 +02:00
parent 2820ee5229
commit f08349247c
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/qemu/qemu_agent.c
View File

@ -1444,12 +1444,6 @@ qemuAgentGetVCPUs(qemuAgentPtr agent,
goto cleanup; goto cleanup;
} }
if (!virJSONValueIsArray(data)) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("Malformed guest-get-vcpus data array"));
goto cleanup;
}
ndata = virJSONValueArraySize(data); ndata = virJSONValueArraySize(data);
*info = g_new0(qemuAgentCPUInfo, ndata); *info = g_new0(qemuAgentCPUInfo, ndata);
@ -2314,12 +2308,6 @@ qemuAgentGetUsers(qemuAgentPtr agent,
return -1; return -1;
} }
if (!virJSONValueIsArray(data)) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("Malformed guest-get-users data array"));
return -1;
}
ndata = virJSONValueArraySize(data); ndata = virJSONValueArraySize(data);
if (virTypedParamsAddUInt(params, nparams, maxparams, if (virTypedParamsAddUInt(params, nparams, maxparams,