External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-28 16:45:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Use qemuDomainCheckABIStability where needed

Browse Source 
Most places which want to check ABI stability for an active domain need
to call this API rather than the original
qemuDomainDefCheckABIStability. The only exception is in snapshots where
we need to decide what to do depending on the saved image data.

https://bugzilla.redhat.com/show_bug.cgi?id=1460952

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Jiri Denemark 2017-06-14 14:56:21 +02:00
parent 063b2b8788
commit f0a3fe1b0a
2 changed files with 42 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
src/qemu/qemu_driver.c
View File

@ -3340,7 +3340,7 @@ qemuDomainSaveInternal(virQEMUDriverPtr driver, virDomainPtr dom,
VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE))) { VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE))) {
goto endjob; goto endjob;
} }
if (!qemuDomainDefCheckABIStability(driver, vm->def, def)) { if (!qemuDomainCheckABIStability(driver, vm, def)) {
virDomainDefFree(def); virDomainDefFree(def);
goto endjob; goto endjob;
} }
@ -15412,39 +15412,50 @@ qemuDomainRevertToSnapshot(virDomainSnapshotPtr snapshot,
* to have finer control. */ * to have finer control. */
if (virDomainObjIsActive(vm)) { if (virDomainObjIsActive(vm)) {
/* Transitions 5, 6, 8, 9 */ /* Transitions 5, 6, 8, 9 */
/* Replace the CPU in config and put the original one in priv
* once we're done.
*/
if (cookie && cookie->cpu && config->cpu) {
origCPU = config->cpu;
if (!(config->cpu = virCPUDefCopy(cookie->cpu)))
goto endjob;
}
/* Check for ABI compatibility. We need to do this check against /* Check for ABI compatibility. We need to do this check against
* the migratable XML or it will always fail otherwise */ * the migratable XML or it will always fail otherwise */
if (config && if (config) {
!qemuDomainDefCheckABIStability(driver, vm->def, config)) { bool compatible;
virErrorPtr err = virGetLastError();
if (!(flags & VIR_DOMAIN_SNAPSHOT_REVERT_FORCE)) { /* Replace the CPU in config and put the original one in priv
/* Re-spawn error using correct category. */ * once we're done. When we have the updated CPU def in the
if (err->code == VIR_ERR_CONFIG_UNSUPPORTED) * cookie, we don't want to replace the CPU in migratable def
virReportError(VIR_ERR_SNAPSHOT_REVERT_RISKY, "%s", * when doing ABI checks to make sure the current CPU exactly
err->str2); * matches the one used at the time the snapshot was taken.
goto endjob; */
if (cookie && cookie->cpu && config->cpu) {
origCPU = config->cpu;
if (!(config->cpu = virCPUDefCopy(cookie->cpu)))
goto endjob;
compatible = qemuDomainDefCheckABIStability(driver, vm->def,
config);
} else {
compatible = qemuDomainCheckABIStability(driver, vm, config);
}
if (!compatible) {
virErrorPtr err = virGetLastError();
if (!(flags & VIR_DOMAIN_SNAPSHOT_REVERT_FORCE)) {
/* Re-spawn error using correct category. */
if (err->code == VIR_ERR_CONFIG_UNSUPPORTED)
virReportError(VIR_ERR_SNAPSHOT_REVERT_RISKY, "%s",
err->str2);
goto endjob;
}
virResetError(err);
qemuProcessStop(driver, vm,
VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT,
QEMU_ASYNC_JOB_START, 0);
virDomainAuditStop(vm, "from-snapshot");
detail = VIR_DOMAIN_EVENT_STOPPED_FROM_SNAPSHOT;
event = virDomainEventLifecycleNewFromObj(vm,
VIR_DOMAIN_EVENT_STOPPED,
detail);
qemuDomainEventQueue(driver, event);
goto load;
} }
virResetError(err);
qemuProcessStop(driver, vm,
VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT,
QEMU_ASYNC_JOB_START, 0);
virDomainAuditStop(vm, "from-snapshot");
detail = VIR_DOMAIN_EVENT_STOPPED_FROM_SNAPSHOT;
event = virDomainEventLifecycleNewFromObj(vm,
VIR_DOMAIN_EVENT_STOPPED,
detail);
qemuDomainEventQueue(driver, event);
goto load;
} }
priv = vm->privateData; priv = vm->privateData;

2
src/qemu/qemu_migration.c
View File

@ -2059,7 +2059,7 @@ qemuMigrationBeginPhase(virQEMUDriverPtr driver,
VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE))) VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE)))
goto cleanup; goto cleanup;
if (!qemuDomainDefCheckABIStability(driver, vm->def, def)) if (!qemuDomainCheckABIStability(driver, vm, def))
goto cleanup; goto cleanup;
rv = qemuDomainDefFormatLive(driver, def, NULL, false, true); rv = qemuDomainDefFormatLive(driver, def, NULL, false, true);