mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-30 09:53:10 +00:00
qemu: fix RBD attach regression
I have been testing libvirt v1.0.0 for deployment within my
organization, and in the process discovered what appears to be a bug
that breaks virsh attach-device, when attaching an RBD volume to an
instance. First, here is the error presented, with v1.0.0 (this worked
in v0.10.2):
[root@host ~]# virsh attach-device W5APQ8 G84VV1.xml
error: Failed to attach device from G84VV1.xml
error: cannot open file 'dc3-1-test/G84VV1': No such file or directory
Using git bisect, I narrowed the problem down to this as the first
commit to break this setup:
4d34c92947
is the first bad commit
This commit is contained in:
parent
bb2f621611
commit
f0e72b2f5c
@ -2028,7 +2028,7 @@ qemuDomainDetermineDiskChain(struct qemud_driver *driver,
|
|||||||
{
|
{
|
||||||
bool probe = driver->allowDiskFormatProbing;
|
bool probe = driver->allowDiskFormatProbing;
|
||||||
|
|
||||||
if (!disk->src)
|
if (!disk->src || disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
if (disk->backingChain) {
|
if (disk->backingChain) {
|
||||||
|
Loading…
Reference in New Issue
Block a user