External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-30 13:37:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

vmx: Rework virVMXConfigScanResultsCollector slightly

Browse Source 
The idea here is that virVMXConfigScanResultsCollector() sets the
networks_max_index to the highest ethernet index seen. Well, the
struct member is signed int, we parse just seen index into uint
and then typecast to compare the two. This is not necessary,
because the maximum number of NICs a vSphere domain can have is
(<drumrolll/>): ten [1]. This will fit into signed int easily
anywhere.

1: https://configmax.esp.vmware.com/guest?vmwareproduct=vSphere&release=vSphere%208.0&categories=1-0

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>
This commit is contained in:
Michal Privoznik 2022-10-17 12:18:40 +02:00
parent c428bccc3f
commit f0fc7cc767
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/vmx/vmx.c
View File

@ -1324,19 +1324,19 @@ virVMXConfigScanResultsCollector(const char* name,
const char *suffix = NULL;
if ((suffix = STRCASESKIP(name, "ethernet"))) {
unsigned int idx;
int idx;
char *p;
if (virStrToLong_uip(suffix, &p, 10, &idx) < 0 ||
*p != '.') {
if (virStrToLong_i(suffix, &p, 10, &idx) < 0 ||
*p != '.' || idx < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_("failed to parse the index of the VMX key '%s'"),
name);
return -1;
}
if ((int)idx > results->networks_max_index)
results->networks_max_index = (int)idx;
if (idx > results->networks_max_index)
results->networks_max_index = idx;
}
return 0;