External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 03:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

virDomainResctrlNew: Refactor allocation to remove 'cleanup' label

Browse Source 
If we use g_new0 there's no need for the 'cleanup' label as there's
nothing to fail after the allocation.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2020-10-02 10:36:59 +02:00
parent 30ff783a80
commit f12f4e2658
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/conf/domain_conf.c
View File

@ -20900,7 +20900,6 @@ virDomainResctrlNew(xmlNodePtr node,
unsigned int flags)
{
virDomainResctrlDefPtr resctrl = NULL;
virDomainResctrlDefPtr ret = NULL;
g_autofree char *vcpus_str = NULL;
g_autofree char *alloc_id = NULL;
@ -20923,18 +20922,13 @@ virDomainResctrlNew(xmlNodePtr node,
}
if (virResctrlAllocSetID(alloc, alloc_id) < 0)
goto cleanup;
if (VIR_ALLOC(resctrl) < 0)
goto cleanup;
return NULL;
resctrl = g_new0(virDomainResctrlDef, 1);
resctrl->vcpus = virBitmapNewCopy(vcpus);
resctrl->alloc = virObjectRef(alloc);
ret = g_steal_pointer(&resctrl);
cleanup:
virDomainResctrlDefFree(resctrl);
return ret;
return resctrl;
}