External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

testCompareXMLToArgvValidateSchema: Improve and fix helper for testing everything

Browse Source 
The schema validator has a comment which allows checking all xml2argv
input files for schema validity by forcing the latest schema onto files
which don't have any schema. Fix it so that it works properly with the
caching introduced in previous commit.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
This commit is contained in:
Peter Krempa 2021-02-19 16:25:29 +01:00
parent 9995a1af45
commit f154e6ddd5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/qemuxml2argvtest.c
View File

@ -528,6 +528,11 @@ testCompareXMLToArgvValidateSchema(virQEMUDriverPtr drv,
unsigned int parseFlags = info->parseFlags;
bool netdevQAPIfied = false;
/* comment out with line comment to enable schema checking for non _CAPS tests
if (!info->schemafile)
info->schemafile = testQemuGetLatestCapsForArch(virArchToString(info->arch), "replies");
// */
if (info->schemafile) {
/* lookup and insert into cache if not found */
if (!g_hash_table_lookup_extended(info->qapiSchemaCache,
@ -540,11 +545,6 @@ testCompareXMLToArgvValidateSchema(virQEMUDriverPtr drv,
}
}
/* comment out with line comment to enable schema checking for non _CAPS tests
if (!schema)
schema = testQEMUSchemaLoadLatest(virArchToString(info->arch));
// */
if (!schema)
return 0;