From f15d4cb1c869ff691b2d6cddbe8463be28d526e1 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 26 Nov 2019 14:14:54 +0100 Subject: [PATCH] qemu: blockjob: Log blockjobs which are dropped when untracked by qemu Since we don't know what happened to the job we can't do much about it but we can at least log that this happened. Signed-off-by: Peter Krempa Reviewed-by: Cole Robinson --- src/qemu/qemu_blockjob.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index 818e36435c..b83d681f06 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -501,8 +501,10 @@ qemuBlockJobRefreshJobs(virQEMUDriverPtr driver, /* remove data for job which qemu didn't report (the algorithm is * inefficient, but the possibility of such jobs is very low */ - while ((job = virHashSearch(priv->blockjobs, qemuBlockJobRefreshJobsFindInactive, NULL, NULL))) + while ((job = virHashSearch(priv->blockjobs, qemuBlockJobRefreshJobsFindInactive, NULL, NULL))) { + VIR_WARN("dropping blockjob '%s' untracked by qemu", job->name); qemuBlockJobUnregister(job, vm); + } ret = 0;