libssh2_session: Add support for creating known_hosts file

The libssh2 code wasn't supposed to create the known_hosts file, but
recent findings show, that we can't use the default created by OpenSSH
as libssh2 might damage it. We need to create a private known_hosts file
in the config path.

This patch adds support for skipping error if the known_hosts file is
not present and let libssh2 create a new one.

src/rpc/virnetsocket.c

@@ -788,8 +788,8 @@ virNetSocketNewConnectLibSSH2(const char *host,
                                                host,
                                                portN,
                                                knownHosts,
-                                               false,
+                                               verify,
-                                               verify) != 0)
+                                               VIR_NET_SSH_HOSTKEY_FILE_CREATE) != 0)
         goto error;
 
     if (virNetSSHSessionSetChannelCommand(sess, command) != 0)

src/rpc/virnetsshsession.c

@@ -1123,8 +1123,8 @@ virNetSSHSessionSetHostKeyVerification(virNetSSHSessionPtr sess,
                                        const char *hostname,
                                        int port,
                                        const char *hostsfile,
-                                       bool readonly,
+                                       virNetSSHHostkeyVerify opt,
-                                       virNetSSHHostkeyVerify opt)
+                                       unsigned int flags)
 {
     char *errmsg;
 
@@ -1140,6 +1140,7 @@ virNetSSHSessionSetHostKeyVerification(virNetSSHSessionPtr sess,
 
     /* load the known hosts file */
     if (hostsfile) {
+        if (virFileExists(hostsfile)) {
             if (libssh2_knownhost_readfile(sess->knownHosts,
                                            hostsfile,
                                            LIBSSH2_KNOWNHOST_FILE_OPENSSH) < 0) {
@@ -1149,10 +1150,15 @@ virNetSSHSessionSetHostKeyVerification(virNetSSHSessionPtr sess,
                                hostsfile, errmsg);
                 goto error;
             }
+        } else if (!(flags & VIR_NET_SSH_HOSTKEY_FILE_CREATE)) {
+            virReportError(VIR_ERR_SSH,
+                           _("known hosts file '%s' does not exist"),
+                           hostsfile);
+            goto error;
+        }
 
         /* set filename only if writing to the known hosts file is requested */
-
+        if (!(flags & VIR_NET_SSH_HOSTKEY_FILE_READONLY)) {
-        if (!readonly) {
             VIR_FREE(sess->knownHostsFile);
             if (!(sess->knownHostsFile = strdup(hostsfile)))
                 goto no_memory;

src/rpc/virnetsshsession.h

@@ -36,6 +36,11 @@ typedef enum {
     VIR_NET_SSH_HOSTKEY_VERIFY_IGNORE
 } virNetSSHHostkeyVerify;
 
+typedef enum {
+    VIR_NET_SSH_HOSTKEY_FILE_READONLY = 1 << 0,
+    VIR_NET_SSH_HOSTKEY_FILE_CREATE   = 1 << 1,
+} virNetSSHHostKeyFileFlags;
+
 int virNetSSHSessionSetChannelCommand(virNetSSHSessionPtr sess,
                                       const char *command);
 
@@ -64,8 +69,8 @@ int virNetSSHSessionSetHostKeyVerification(virNetSSHSessionPtr sess,
                                            const char *hostname,
                                            int port,
                                            const char *hostsfile,
-                                           bool readonly,
+                                           virNetSSHHostkeyVerify opt,
-                                           virNetSSHHostkeyVerify opt);
+                                           unsigned int flags);
 
 int virNetSSHSessionConnect(virNetSSHSessionPtr sess,
                             int sock);