External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-28 22:32:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

utils: Canonicalize paths before comparing them

Browse Source 
In virFileIsSharedFSOverride() we compare a path against a list
of overrides looking for a match.

All overrides are canonicalized ahead of time though, so e.g.
/var/run/foo will be turned into /run/foo due to /var/run being
a symlink on modern Linux systems. But the path we're trying to
match with the overrides doesn't get the same treatment, so in
this scenario the comparison will always fail.

Canonicalizing the path as well solves the issue.

Resolves: https://issues.redhat.com/browse/RHEL-79165
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Andrea Bolognani 2025-02-13 09:54:05 +01:00
parent b5dfcdc7ab
commit f2023e8018
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/util/virfile.c
View File

@ -3823,10 +3823,13 @@ virFileIsSharedFSOverride(const char *path,
if (!path || path[0] != '/' || !overrides)
return false;
if (g_strv_contains((const char *const *) overrides, path))
return true;
/* Overrides have been canonicalized ahead of time, so we need to
* do the same for the provided path or we'll never be able to
* find a match if symlinks are involved */
dirpath = virFileCanonicalizePath(path);
dirpath = g_strdup(path);
if (g_strv_contains((const char *const *) overrides, dirpath))
return true;
/* Continue until we've scanned the entire path */
while (p != dirpath) {