External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 14:15:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Resolve Coverity FORWARD_NULL

Browse Source 
If we jump to cleanup before allocating the 'result', then the call
to virBlkioDeviceArrayClear will deref result causing a problem.

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2014-09-04 16:24:37 -04:00
parent 0311be9435
commit f28a31fcc4
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu/qemu_driver.c
View File

@ -7683,8 +7683,10 @@ qemuDomainParseBlkioDeviceStr(char *blkioDeviceStr, const char *type,
_("unable to parse blkio device '%s' '%s'"), _("unable to parse blkio device '%s' '%s'"),
type, blkioDeviceStr); type, blkioDeviceStr);
cleanup: cleanup:
virBlkioDeviceArrayClear(result, ndevices); if (result) {
VIR_FREE(result); virBlkioDeviceArrayClear(result, ndevices);
VIR_FREE(result);
}
return -1; return -1;
} }