mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 05:35:25 +00:00
virMdevctlList: Don't check for !output
After 'mdevctl' was ran, its stdout is captured in @output which is then compared against NULL and if it is NULL a negative value is returned (to indicate error to the caller). But this is effectively a dead code, because virCommand (specifically virCommandProcessIO()) makes sure both stdout and stderr buffers are properly '\0' terminated. Therefore, this can never evaluate to true. Also, if there really is no output from 'mdevctl' (which was handled in one of earlier commits, but let just assume it wasn't), then we should not error out and treat such scenario as 'no mdevs defined/active'. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
This commit is contained in:
parent
035d5ed80c
commit
f3a7b3e85b
@ -1650,9 +1650,6 @@ virMdevctlList(bool defined,
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (!output)
|
||||
return -1;
|
||||
|
||||
return nodeDeviceParseMdevctlJSON(output, devs);
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user