virsh: domain: Fix option handling in domxml-to-native

Commit fdeac7a05f tried to fix the output
of 'virsh domxml-to-native --help' by switching types around. One of the
changes broke the option parser. VSH_OT_ARGV should be used only for
variable argument count, not to make the help generator look pretty.

The correct option type in this case is VSH_OT_STRING as it's not
mandatory now since it can be substituted by using --domain.

This makes --help for this command look incorrect, but the parser works
as it should.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1494400
This commit is contained in:
Peter Krempa 2017-10-10 17:19:10 +02:00
parent f26636887f
commit f4973d1ea8

View File

@ -10152,7 +10152,7 @@ static const vshCmdOptDef opts_domxmltonative[] = {
.help = N_("domain name, id or uuid")
},
{.name = "xml",
.type = VSH_OT_ARGV,
.type = VSH_OT_STRING,
.help = N_("xml data file to export from")
},
{.name = NULL}