External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-27 15:05:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reset the whole stack in testutils

Browse Source 
The memset() was resetting only 30 bytes in the array (size of the
array), but it is array of pointers.  Since it is a static array,
let's just reset it by its size.

Found by gcc-7.1:

  testutils.c: In function 'virTestRun':
  testutils.c:243:13: error: 'memset' used with length equal to number
  of elements without multiplication by element size [-Werror=memset-elt-size]
    memset(testAllocStack, 0, ARRAY_CARDINALITY(testAllocStack));
    ^~~~~~

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Martin Kletzander 2017-06-05 09:38:31 +02:00
parent 0ab409ccc4
commit f4c09b913e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/testutils.c
View File

@ -240,7 +240,7 @@ virTestRun(const char *title,
for (i = start; i < end; i++) { for (i = start; i < end; i++) {
bool missingFail = false; bool missingFail = false;
# ifdef TEST_OOM_TRACE # ifdef TEST_OOM_TRACE
memset(testAllocStack, 0, ARRAY_CARDINALITY(testAllocStack)); memset(testAllocStack, 0, sizeof(testAllocStack));
ntestAllocStack = 0; ntestAllocStack = 0;
# endif # endif
virAllocTestOOM(i + 1, 1); virAllocTestOOM(i + 1, 1);