diff --git a/src/fdstream.c b/src/fdstream.c index d236318994..4cf152a075 100644 --- a/src/fdstream.c +++ b/src/fdstream.c @@ -577,7 +577,8 @@ virFDStreamOpenFileInternal(virStreamPtr st, unsigned long long offset, unsigned long long length, int oflags, - int mode) + int mode, + bool forceIOHelper) { int fd = -1; int childfd = -1; @@ -623,8 +624,8 @@ virFDStreamOpenFileInternal(virStreamPtr st, * the I/O so we just have a fifo. Or use AIO :-( */ if ((st->flags & VIR_STREAM_NONBLOCK) && - (!S_ISCHR(sb.st_mode) && - !S_ISFIFO(sb.st_mode))) { + ((!S_ISCHR(sb.st_mode) && + !S_ISFIFO(sb.st_mode)) || forceIOHelper)) { int fds[2] = { -1, -1 }; if ((oflags & O_ACCMODE) == O_RDWR) { @@ -703,7 +704,7 @@ int virFDStreamOpenFile(virStreamPtr st, } return virFDStreamOpenFileInternal(st, path, offset, length, - oflags, 0); + oflags, 0, false); } int virFDStreamCreateFile(virStreamPtr st, @@ -715,7 +716,8 @@ int virFDStreamCreateFile(virStreamPtr st, { return virFDStreamOpenFileInternal(st, path, offset, length, - oflags | O_CREAT, mode); + oflags | O_CREAT, mode, + false); } #ifdef HAVE_CFMAKERAW @@ -730,7 +732,8 @@ int virFDStreamOpenPTY(virStreamPtr st, if (virFDStreamOpenFileInternal(st, path, offset, length, - oflags | O_CREAT, 0) < 0) + oflags | O_CREAT, 0, + false) < 0) return -1; fdst = st->privateData; @@ -770,6 +773,17 @@ int virFDStreamOpenPTY(virStreamPtr st, } #endif /* !HAVE_CFMAKERAW */ +int virFDStreamOpenBlockDevice(virStreamPtr st, + const char *path, + unsigned long long offset, + unsigned long long length, + int oflags) +{ + return virFDStreamOpenFileInternal(st, path, + offset, length, + oflags, 0, true); +} + int virFDStreamSetInternalCloseCb(virStreamPtr st, virFDStreamInternalCloseCb cb, void *opaque, diff --git a/src/fdstream.h b/src/fdstream.h index 69d832817e..2c913ea140 100644 --- a/src/fdstream.h +++ b/src/fdstream.h @@ -56,6 +56,11 @@ int virFDStreamOpenPTY(virStreamPtr st, unsigned long long offset, unsigned long long length, int oflags); +int virFDStreamOpenBlockDevice(virStreamPtr st, + const char *path, + unsigned long long offset, + unsigned long long length, + int oflags); int virFDStreamSetInternalCloseCb(virStreamPtr st, virFDStreamInternalCloseCb cb, diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index e09ddd57cc..6b9ee21c74 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -823,6 +823,7 @@ virStreamClass; virFDStreamConnectUNIX; virFDStreamCreateFile; virFDStreamOpen; +virFDStreamOpenBlockDevice; virFDStreamOpenFile; virFDStreamOpenPTY; virFDStreamSetInternalCloseCb; diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index 9c775c9557..00cfe74c88 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -1718,7 +1718,8 @@ virStorageBackendVolUploadLocal(virConnectPtr conn ATTRIBUTE_UNUSED, /* Not using O_CREAT because the file is required to already exist at * this point */ - return virFDStreamOpenFile(stream, vol->target.path, offset, len, O_WRONLY); + return virFDStreamOpenBlockDevice(stream, vol->target.path, + offset, len, O_WRONLY); } int @@ -1732,7 +1733,8 @@ virStorageBackendVolDownloadLocal(virConnectPtr conn ATTRIBUTE_UNUSED, { virCheckFlags(0, -1); - return virFDStreamOpenFile(stream, vol->target.path, offset, len, O_RDONLY); + return virFDStreamOpenBlockDevice(stream, vol->target.path, + offset, len, O_RDONLY); }