External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-30 13:37:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: snapshot: Properly handle image locking

Browse Source 
Images that became the backing chain of the current image due to the
snapshot need to be unlocked in the lock manager. Also if qemu was
paused during the snapshot the current top level images need to be
released until qemu is resumed so that they can be acquired properly.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1191901
This commit is contained in:
Peter Krempa 2016-12-16 15:45:26 +01:00
parent cbb4d229de
commit f61e40610d
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/qemu/qemu_driver.c
View File

@ -14486,6 +14486,23 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver,
virStorageFileUnlink(diskdata[i].src) < 0)
VIR_WARN("Unable to remove just-created %s", diskdata[i].src->path);
}
} else {
/* on successful snapshot we need to remove locks from the now-old
* disks and if the VM is paused release locks on the images since qemu
* stopped using them*/
bool paused = virDomainObjGetState(vm, NULL) != VIR_DOMAIN_RUNNING;
for (i = 0; i < snap->def->ndisks; i++) {
if (!diskdata[i].disk)
continue;
if (paused)
virDomainLockImageDetach(driver->lockManager, vm,
diskdata[i].disk->src);
virDomainLockImageDetach(driver->lockManager, vm,
diskdata[i].disk->src->backingStore);
}
}
if (ret == 0 || !actions) {