External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

nwfilter: wire up new APIs for listing and querying filter bindings

Browse Source 
Wire up the ListAll, LookupByPortDev and GetXMLDesc APIs to allow the
virsh nwfilter-binding-list & nwfilter-binding-dumpxml commands to
work.

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2018-05-10 14:12:40 +01:00
parent 3df907bfff
commit f61ea979a4
1 changed files with 76 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
src/nwfilter/nwfilter_driver.c
View File

@ -714,6 +714,79 @@ nwfilterTeardownFilter(virDomainNetDefPtr net)
}
static virNWFilterBindingPtr
nwfilterBindingLookupByPortDev(virConnectPtr conn,
const char *portdev)
{
virNWFilterBindingPtr ret = NULL;
virNWFilterBindingObjPtr obj;
virNWFilterBindingDefPtr def;
obj = virNWFilterBindingObjListFindByPortDev(driver->bindings,
portdev);
if (!obj)
goto cleanup;
def = virNWFilterBindingObjGetDef(obj);
if (virNWFilterBindingLookupByPortDevEnsureACL(conn, def) < 0)
goto cleanup;
ret = virGetNWFilterBinding(conn, def->portdevname, def->filter);
cleanup:
virNWFilterBindingObjEndAPI(&obj);
return ret;
}
static int
nwfilterConnectListAllNWFilterBindings(virConnectPtr conn,
virNWFilterBindingPtr **bindings,
unsigned int flags)
{
int ret;
virCheckFlags(0, -1);
if (virConnectListAllNWFilterBindingsEnsureACL(conn) < 0)
return -1;
ret = virNWFilterBindingObjListExport(driver->bindings,
conn,
bindings,
virConnectListAllNWFilterBindingsCheckACL);
return ret;
}
static char *
nwfilterBindingGetXMLDesc(virNWFilterBindingPtr binding,
unsigned int flags)
{
virNWFilterBindingObjPtr obj;
virNWFilterBindingDefPtr def;
char *ret = NULL;
virCheckFlags(0, NULL);
obj = virNWFilterBindingObjListFindByPortDev(driver->bindings,
binding->portdev);
if (!obj)
goto cleanup;
def = virNWFilterBindingObjGetDef(obj);
if (virNWFilterBindingGetXMLDescEnsureACL(binding->conn, def) < 0)
goto cleanup;
ret = virNWFilterBindingDefFormat(def);
cleanup:
virNWFilterBindingObjEndAPI(&obj);
return ret;
}
static virNWFilterDriver nwfilterDriver = {
.name = "nwfilter",
.connectNumOfNWFilters = nwfilterConnectNumOfNWFilters, /* 0.8.0 */
@ -724,6 +797,9 @@ static virNWFilterDriver nwfilterDriver = {
.nwfilterDefineXML = nwfilterDefineXML, /* 0.8.0 */
.nwfilterUndefine = nwfilterUndefine, /* 0.8.0 */
.nwfilterGetXMLDesc = nwfilterGetXMLDesc, /* 0.8.0 */
.nwfilterBindingLookupByPortDev = nwfilterBindingLookupByPortDev, /* 4.5.0 */
.connectListAllNWFilterBindings = nwfilterConnectListAllNWFilterBindings, /* 4.5.0 */
.nwfilterBindingGetXMLDesc = nwfilterBindingGetXMLDesc, /* 4.5.0 */
};