External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 03:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

virnetdevtap: Add better error message for a possible common user error

Browse Source 
When users pre-create a tap device to use with multiqueue interface that
has `managed="no"`, change the error so that it does not indicate we are
trying to create the device, and on top of that hint at the most
probable error cause.

Resolves: https://issues.redhat.com/browse/RHEL-55749
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Martin Kletzander 2024-09-04 10:18:41 +02:00
parent 4ce9196dc4
commit f6fb097e11
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/util/virnetdevtap.c
View File

@ -230,9 +230,16 @@ int virNetDevTapCreate(char **ifname,
} }
if (ioctl(fd, TUNSETIFF, &ifr) < 0) { if (ioctl(fd, TUNSETIFF, &ifr) < 0) {
virReportSystemError(errno, if (flags & VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING &&
_("Unable to create tap device %1$s"), tapfdSize > 0) {
*ifname); virReportSystemError(errno,
_("Unable to create multiple fds for tap device %1$s (maybe existing device was created without multi_queue flag)"),
*ifname);
} else {
virReportSystemError(errno,
_("Unable to create tap device %1$s"),
*ifname);
}
goto cleanup; goto cleanup;
} }