External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

util: Alter virAuthGet*Path API to check valid parameters

Browse Source 
Before trying to dereference @auth, let's ensure it's valid.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
This commit is contained in:
John Ferlan 2018-08-14 10:03:10 -04:00
parent bfd91dc0c4
commit f707935abf
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/util/virauth.c
View File

@ -153,6 +153,12 @@ virAuthGetUsernamePath(const char *path,
if (ret != NULL) if (ret != NULL)
return ret; return ret;
if (!auth) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
_("Missing authentication credentials"));
return NULL;
}
memset(&cred, 0, sizeof(virConnectCredential)); memset(&cred, 0, sizeof(virConnectCredential));
if (defaultUsername != NULL) { if (defaultUsername != NULL) {
@ -226,6 +232,12 @@ virAuthGetPasswordPath(const char *path,
if (ret != NULL) if (ret != NULL)
return ret; return ret;
if (!auth) {
virReportError(VIR_ERR_INVALID_ARG, "%s",
_("Missing authentication credentials"));
return NULL;
}
memset(&cred, 0, sizeof(virConnectCredential)); memset(&cred, 0, sizeof(virConnectCredential));
if (virAsprintf(&prompt, _("Enter %s's password for %s"), username, if (virAsprintf(&prompt, _("Enter %s's password for %s"), username,