External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-11-09 23:10:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly convert type to double to avoid losing precision

Browse Source 
Division between integers will also be integer.
Thus, to preserve fractional part explicitly
convert first operand to double.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 28d54aab05 ("examples: Introduce domtop")
Signed-off-by: Egor Makrushin <emakrushin@astralinux.ru>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Egor Makrushin 2024-01-23 12:28:34 +03:00 committed by Martin Kletzander
parent ab9da5c4ab
commit f70b7c9772
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/c/domain/domtop.c
View File

@ -224,7 +224,7 @@ print_cpu_usage(size_t cpu,
* performed has a bad effect on the precision, so instead of dividing * performed has a bad effect on the precision, so instead of dividing
* @now_params and @then_params by 1000 and then multiplying again by * @now_params and @then_params by 1000 and then multiplying again by
* 100, we divide only once by 10 and get the same result. */ * 100, we divide only once by 10 and get the same result. */
usage = (now_params[pos].value.ul - then_params[pos].value.ul) / usage = (double)(now_params[pos].value.ul - then_params[pos].value.ul) /
(now - then) / 10; (now - then) / 10;
if (delim) if (delim)