External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 03:12:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

src: Drop needless typecast to virDomainDiskBus

Browse Source 
The 'bus' member of _virDomainDiskDef is already declared of
virDomainDiskModel type. Hence, there is no need to typecast the
variable when passing to switch() statements.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik 2023-09-13 17:30:45 +02:00
parent 0041723233
commit f7534c2573
6 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_alias.c
View File

@ -244,7 +244,7 @@ qemuAssignDeviceDiskAlias(virDomainDef *def,
* need the full path into /machine/peripheral as a historical artifact.
*/
if (!diskPriv->qomName) {
switch ((virDomainDiskBus) disk->bus) {
switch (disk->bus) {
case VIR_DOMAIN_DISK_BUS_FDC:
case VIR_DOMAIN_DISK_BUS_IDE:
case VIR_DOMAIN_DISK_BUS_SATA:

4
src/qemu/qemu_command.c
View File

@ -409,7 +409,7 @@ qemuBuildDeviceAddresDriveProps(virJSONValue *props,
virDomainControllerDef *controller = NULL;
const char *controllerAlias = NULL;
switch ((virDomainDiskBus) info->addr.drive.diskbus) {
switch (info->addr.drive.diskbus) {
case VIR_DOMAIN_DISK_BUS_IDE:
/* When domain has builtin IDE controller we don't put it onto cmd
* line. Therefore we can't set its alias. In that case, use the
@ -1770,7 +1770,7 @@ qemuBuildDiskDeviceProps(const virDomainDef *def,
const char *wpolicy = NULL;
const char *rpolicy = NULL;
switch ((virDomainDiskBus) disk->bus) {
switch (disk->bus) {
case VIR_DOMAIN_DISK_BUS_IDE:
case VIR_DOMAIN_DISK_BUS_SATA:
if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM)

2
src/qemu/qemu_domain_address.c
View File

@ -790,7 +790,7 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDef *dev,
break;
case VIR_DOMAIN_DEVICE_DISK:
switch ((virDomainDiskBus) dev->data.disk->bus) {
switch (dev->data.disk->bus) {
case VIR_DOMAIN_DISK_BUS_VIRTIO:
/* only virtio disks use PCI */
switch (dev->data.disk->model) {

4
src/qemu/qemu_hotplug.c
View File

@ -926,7 +926,7 @@ qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriver *driver,
goto cleanup;
}
switch ((virDomainDiskBus) disk->bus) {
switch (disk->bus) {
case VIR_DOMAIN_DISK_BUS_USB:
if (disk->device == VIR_DOMAIN_DISK_DEVICE_LUN) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
@ -5468,7 +5468,7 @@ qemuDomainDetachPrepDisk(virDomainObj *vm,
case VIR_DOMAIN_DISK_DEVICE_DISK:
case VIR_DOMAIN_DISK_DEVICE_LUN:
switch ((virDomainDiskBus) disk->bus) {
switch (disk->bus) {
case VIR_DOMAIN_DISK_BUS_VIRTIO:
case VIR_DOMAIN_DISK_BUS_USB:
case VIR_DOMAIN_DISK_BUS_SCSI:

4
src/qemu/qemu_validate.c
View File

@ -1371,7 +1371,7 @@ qemuValidateDomainDeviceDefAddressDrive(virDomainDeviceInfo *info,
{
virDomainControllerDef *controller = NULL;
switch ((virDomainDiskBus) info->addr.drive.diskbus) {
switch (info->addr.drive.diskbus) {
case VIR_DOMAIN_DISK_BUS_SCSI:
/* Setting bus= attr for SCSI drives, causes a controller
* to be created. Yes this is slightly odd. It is not possible
@ -2673,7 +2673,7 @@ static bool
qemuValidateDomainDeviceDefDiskIOThreads(const virDomainDef *def,
const virDomainDiskDef *disk)
{
switch ((virDomainDiskBus)disk->bus) {
switch (disk->bus) {
case VIR_DOMAIN_DISK_BUS_VIRTIO:
break;

2
src/vbox/vbox_common.c
View File

@ -1206,7 +1206,7 @@ vboxAttachDrives(virDomainDef *def, struct _vboxDriver *data, IMachine *machine)
goto cleanup;
}
switch ((virDomainDiskBus) disk->bus) {
switch (disk->bus) {
case VIR_DOMAIN_DISK_BUS_IDE:
VBOX_UTF8_TO_UTF16(VBOX_CONTROLLER_IDE_NAME, &storageCtlName);
devicePort = def->disks[i]->info.addr.drive.bus;