External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-12 21:05:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

vsh: Drop useless check for cmd != NULL

Browse Source 
All our internal *Free() functions are capable of handling NULL.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2018-01-02 14:33:45 +01:00
parent 8010997e2c
commit f784403093
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/vsh.c
View File

@ -1392,10 +1392,8 @@ vshCommandParse(vshControl *ctl, vshCommandParser *parser)
vshCmd *clast = NULL; vshCmd *clast = NULL;
vshCmdOpt *first = NULL; vshCmdOpt *first = NULL;
if (ctl->cmd) { vshCommandFree(ctl->cmd);
vshCommandFree(ctl->cmd); ctl->cmd = NULL;
ctl->cmd = NULL;
}
while (1) { while (1) {
vshCmdOpt *last = NULL; vshCmdOpt *last = NULL;
@ -1576,10 +1574,8 @@ vshCommandParse(vshControl *ctl, vshCommandParser *parser)
return true; return true;
syntaxError: syntaxError:
if (ctl->cmd) { vshCommandFree(ctl->cmd);
vshCommandFree(ctl->cmd); ctl->cmd = NULL;
ctl->cmd = NULL;
}
vshCommandOptFree(first); vshCommandOptFree(first);
VIR_FREE(tkdata); VIR_FREE(tkdata);
return false; return false;