External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 03:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

virfile: add comment about the use of SEEK_END in virFileDiskCopy

Browse Source 
Signed-off-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Claudio Fontana 2022-05-06 15:10:50 +02:00 committed by Daniel P. Berrangé
parent 8c09638514
commit f79de95b16
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/util/virfile.c
View File

@ -4741,6 +4741,10 @@ virFileDiskCopy(int disk_fd, const char *disk_path, int remote_fd, const char *r
if (!p.isBlockDev && p.isDirect) {
off_t off;
if (p.isWrite) {
/*
* note: for write we do not only check that disk_fd is seekable,
* we also want to know that the file is empty, so we need SEEK_END.
*/
if ((off = lseek(disk_fd, 0, SEEK_END)) != 0) {
virReportSystemError(off < 0 ? errno : EINVAL, "%s",
_("O_DIRECT write needs empty seekable file"));