External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-20 03:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't autostart domains when reloading config

Browse Source 
When sending SIGHUP to libvirtd, it will trigger the virStateDriver
reload operation. This is intended to reload the configuration files
for guests. For unknown historical reasons this is also triggering
autostart of all guests. Autostart is generally expected to be
something that happens on OS startup. Starting VMs on SIGHUP will
violate that expectation and potentially cause dangerous scenarios
if the admin has explicitly shutdown a misbehaving VM that has
been marked as autostart

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit 95c2c19f06298a6e93849d9a5da8161460c33f43)
This commit is contained in:
Daniel P. Berrange 2012-07-13 12:49:55 +01:00 committed by Cole Robinson
parent d4ffc36fbc
commit f81800cf23
3 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lxc/lxc_driver.c
View File

@ -2687,8 +2687,6 @@ lxcReload(void) {
lxcNotifyLoadDomain, lxc_driver);
lxcDriverUnlock(lxc_driver);
lxcAutostartConfigs(lxc_driver);
return 0;
}

2
src/qemu/qemu_driver.c
View File

@ -783,8 +783,6 @@ qemudReload(void) {
qemudNotifyLoadDomain, qemu_driver);
qemuDriverUnlock(qemu_driver);
qemuAutostartDomains(qemu_driver);
return 0;
}

2
src/uml/uml_driver.c
View File

@ -553,8 +553,6 @@ umlReload(void) {
umlNotifyLoadDomain, uml_driver);
umlDriverUnlock(uml_driver);
umlAutostartConfigs(uml_driver);
return 0;
}