External/libvirt
1
0
Fork 0
Code

cpu_x86: Handle error in x86DataToCPU when calling x86DataAdd

Browse Source 
Commit 9c9620af called x86DataAdd without checking for an error,
so add the error checking.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
John Ferlan 2019-06-21 13:10:35 -04:00
parent 5acb4eede2
commit fa7d0cc1e7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cpu/cpu_x86.c
View File

@ -822,7 +822,8 @@ x86DataToCPU(const virCPUx86Data *data,
for (blocker = hvModel->blockers; *blocker; blocker++) {
if ((feature = x86FeatureFind(map, *blocker)) &&
!x86DataIsSubset(&copy, &feature->data))
x86DataAdd(&modelData, &feature->data);
if (x86DataAdd(&modelData, &feature->data) < 0)
goto error;
}
}