External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-21 12:05:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

More coverity findings addressed

Browse Source 
More bug extermination in the category of:

Error: CHECKED_RETURN:

/libvirt/src/conf/network_conf.c:595:
check_return: Calling function "virAsprintf" without checking return value (as is done elsewhere 515 out of 543 times).

/libvirt/src/qemu/qemu_process.c:2780:
unchecked_value: No check of the return value of "virAsprintf(&msg, "was paused (%s)", virDomainPausedReasonTypeToString(reason))".

/libvirt/tests/commandtest.c:809:
check_return: Calling function "setsid" without checking return value (as is done elsewhere 4 out of 5 times).

/libvirt/tests/commandtest.c:830:
unchecked_value: No check of the return value of "virTestGetDebug()".

/libvirt/tests/commandtest.c:831:
check_return: Calling function "virTestGetVerbose" without checking return value (as is done elsewhere 41 out of 42 times).

/libvirt/tests/commandtest.c:833:
check_return: Calling function "virInitialize" without checking return value (as is done elsewhere 18 out of 21 times).

One note about the error in commandtest line 809: setsid() seems to fail when running the test -- could be removed ?

(cherry picked from commit 59b935f5ae92e0833e71cc3b490cf1e24eee43fb)
This commit is contained in:
Stefan Berger 2012-04-27 17:25:35 -04:00 committed by Cole Robinson
parent ce43e865a1
commit fae6eb83e7
3 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/conf/network_conf.c
View File

@ -590,12 +590,9 @@ virNetworkDNSSrvDefParseXML(virNetworkDNSDefPtr def,
} }
if (strlen(service) > DNS_RECORD_LENGTH_SRV) { if (strlen(service) > DNS_RECORD_LENGTH_SRV) {
char *name = NULL;
virAsprintf(&name, _("Service name is too long, limit is %d bytes"), DNS_RECORD_LENGTH_SRV);
virNetworkReportError(VIR_ERR_XML_DETAIL, virNetworkReportError(VIR_ERR_XML_DETAIL,
"%s", name); _("Service name is too long, limit is %d bytes"),
VIR_FREE(name); DNS_RECORD_LENGTH_SRV);
goto error; goto error;
} }

4
src/qemu/qemu_process.c
View File

@ -2781,8 +2781,8 @@ qemuProcessUpdateState(struct qemud_driver *driver, virDomainObjPtr vm)
} else { } else {
newState = VIR_DOMAIN_PAUSED; newState = VIR_DOMAIN_PAUSED;
newReason = reason; newReason = reason;
virAsprintf(&msg, "was paused (%s)", ignore_value(virAsprintf(&msg, "was paused (%s)",
virDomainPausedReasonTypeToString(reason)); virDomainPausedReasonTypeToString(reason)));
} }
} else if (state == VIR_DOMAIN_SHUTOFF && running) { } else if (state == VIR_DOMAIN_SHUTOFF && running) {
newState = VIR_DOMAIN_RUNNING; newState = VIR_DOMAIN_RUNNING;

9
tests/commandtest.c
View File

@ -806,7 +806,7 @@ mymain(void)
return EXIT_FAILURE; return EXIT_FAILURE;
setpgid(0, 0); setpgid(0, 0);
setsid(); ignore_value(setsid());
/* Our test expects particular fd values; to get that, we must not /* Our test expects particular fd values; to get that, we must not
* leak fds that we inherited from a lazy parent. At the same * leak fds that we inherited from a lazy parent. At the same
@ -827,10 +827,11 @@ mymain(void)
/* Prime the debug/verbose settings from the env vars, /* Prime the debug/verbose settings from the env vars,
* since we're about to reset 'environ' */ * since we're about to reset 'environ' */
virTestGetDebug(); ignore_value(virTestGetDebug());
virTestGetVerbose(); ignore_value(virTestGetVerbose());
virInitialize(); if (virInitialize() < 0)
return EXIT_FAILURE;
/* Phase two of killing interfering fds; see above. */ /* Phase two of killing interfering fds; see above. */
fd = 3; fd = 3;