mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-02-21 19:02:25 +00:00
util: storagefile: Don't crash on gluster URIs without path
Similar to commit fdb80ed4f6563928b9942a0d1450e0c725aa6c06 libvirtd would crash if a gluster URI without path would be used in the backing chain of a volume. The crash happens in the gluster specific part of the parser that extracts the gluster volume name from the path. Fix the crash by checking that the PATH is NULL. This patch does not contain a test case as it's not possible to test it with the current infrastructure as the test suite would attempt to contact the gluster server in the URI. I'm working on the test suite addition but that will be post-release material. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1196528
This commit is contained in:
parent
b15b21f3a5
commit
fc56ecd735
@ -2163,6 +2163,13 @@ virStorageSourceParseBackingURI(virStorageSourcePtr src,
|
||||
|
||||
if (src->protocol == VIR_STORAGE_NET_PROTOCOL_GLUSTER) {
|
||||
char *tmp;
|
||||
|
||||
if (!src->path) {
|
||||
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
_("missing volume name and path for gluster volume"));
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
if (!(tmp = strchr(src->path, '/')) ||
|
||||
tmp == src->path) {
|
||||
virReportError(VIR_ERR_XML_ERROR,
|
||||
|
Loading…
x
Reference in New Issue
Block a user