External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-30 13:37:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "storage: Better describe logical pool creation/definition parameters"

Browse Source 
This reverts commit ca4515d263
which also included a functional change that broke logical storage pools
not named after their volume groups.
This commit is contained in:
Ján Tomko 2017-03-28 09:45:10 +02:00
parent efb446e1b0
commit fcb90d72ab
2 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/conf/storage_conf.c
View File

@ -760,14 +760,6 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt)
if (VIR_STRDUP(ret->source.name, ret->name) < 0)
goto error;
}
if (ret->type == VIR_STORAGE_POOL_LOGICAL &&
STRNEQ(ret->name, ret->source.name)) {
virReportError(VIR_ERR_XML_ERROR,
_("for a logical pool, the pool name='%s' "
"must match the pool source name='%s'"),
ret->name, ret->source.name);
goto error;
}
}
if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) &&

7
tools/virsh.pod
View File

@ -3639,13 +3639,6 @@ follow-up command to build the pool. The I<--overwrite> and
I<--no-overwrite> flags follow the same rules as B<pool-build>. If
just I<--build> is provided, then B<pool-build> is called with no flags.
For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>]
must match the Volume Group name for which the pool is being defined or
created. The [I<--source-name>] if provided must match the Volume Group
name. If not provided, one will be generated using the [I<--name>]. If
provided the [I<--target>] is ignored and a target source is generated
using the [I<--source-name>] (or as generated from the [I<--name>]).
=item B<pool-define> I<file>
Define an inactive persistent storage pool or modify an existing persistent one