External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuBuildCommandLine: Remove 'flags' argument

Browse Source 
The flags are not used for anything.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Peter Krempa 2022-05-16 13:55:25 +02:00
parent bab089d379
commit fcd7741c48
6 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/qemu/qemu_command.c
View File

@ -10400,8 +10400,7 @@ qemuBuildCommandLine(virDomainObj *vm,
virDomainMomentObj *snapshot,
virNetDevVPortProfileOp vmop,
size_t *nnicindexes,
int **nicindexes,
unsigned int flags)
int **nicindexes)
{
size_t i;
char uuid[VIR_UUID_STRING_BUFLEN];
@ -10412,8 +10411,8 @@ qemuBuildCommandLine(virDomainObj *vm,
virDomainDef *def = vm->def;
virQEMUCaps *qemuCaps = priv->qemuCaps;
VIR_DEBUG("Building qemu commandline for def=%s(%p) migrateURI=%s snapshot=%p vmop=%d flags=0x%x",
def->name, def, migrateURI, snapshot, vmop, flags);
VIR_DEBUG("Building qemu commandline for def=%s(%p) migrateURI=%s snapshot=%p vmop=%d",
def->name, def, migrateURI, snapshot, vmop);
if (qemuBuildCommandLineValidate(driver, def) < 0)
return NULL;

3
src/qemu/qemu_command.h
View File

@ -48,8 +48,7 @@ virCommand *qemuBuildCommandLine(virDomainObj *vm,
virDomainMomentObj *snapshot,
virNetDevVPortProfileOp vmop,
size_t *nnicindexes,
int **nicindexes,
unsigned int flags);
int **nicindexes);
/* Generate the object properties for pr-manager */
virJSONValue *qemuBuildPRManagerInfoProps(virStorageSource *src);

2
src/qemu/qemu_driver.c
View File

@ -6390,7 +6390,7 @@ static char *qemuConnectDomainXMLToNative(virConnectPtr conn,
if (qemuConnectDomainXMLToNativePrepareHost(vm) < 0)
return NULL;
if (!(cmd = qemuProcessCreatePretendCmdBuild(vm, NULL, 0)))
if (!(cmd = qemuProcessCreatePretendCmdBuild(vm, NULL)))
return NULL;
return virCommandToString(cmd, false);

8
src/qemu/qemu_process.c
View File

@ -7448,7 +7448,7 @@ qemuProcessLaunch(virConnectPtr conn,
if (!(cmd = qemuBuildCommandLine(vm,
incoming ? "defer" : NULL,
snapshot, vmop,
&nnicindexes, &nicindexes, 0)))
&nnicindexes, &nicindexes)))
goto cleanup;
if (incoming && incoming->fd != -1)
@ -7945,16 +7945,14 @@ qemuProcessCreatePretendCmdPrepare(virQEMUDriver *driver,
virCommand *
qemuProcessCreatePretendCmdBuild(virDomainObj *vm,
const char *migrateURI,
unsigned int flags)
const char *migrateURI)
{
return qemuBuildCommandLine(vm,
migrateURI,
NULL,
VIR_NETDEV_VPORT_PROFILE_OP_NO_OP,
NULL,
NULL,
flags);
NULL);
}

3
src/qemu/qemu_process.h
View File

@ -98,8 +98,7 @@ int qemuProcessCreatePretendCmdPrepare(virQEMUDriver *driver,
unsigned int flags);
virCommand *qemuProcessCreatePretendCmdBuild(virDomainObj *vm,
const char *migrateURI,
unsigned int flags);
const char *migrateURI);
int qemuProcessInit(virQEMUDriver *driver,
virDomainObj *vm,

2
tests/qemuxml2argvtest.c
View File

@ -484,7 +484,7 @@ testCompareXMLToArgvCreateArgs(virQEMUDriver *drv,
}
}
return qemuProcessCreatePretendCmdBuild(vm, migrateURI, 0);
return qemuProcessCreatePretendCmdBuild(vm, migrateURI);
}