From fd5df67dce231b447e02b8ba6648d158b84cc584 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Fri, 20 Nov 2020 14:05:54 +0100 Subject: [PATCH] udevConnectListAllInterfaces: initialize ret MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, ret is only used in the 'cleanup' section and initialized right before the jump. Switch to the customary initialization to -1 and only leave in the 'ret = 0' statement on an empty list. Signed-off-by: Ján Tomko Reviewed-by: Michal Privoznik --- src/interface/interface_backend_udev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index ce007fd29e..31246dde74 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -303,7 +303,7 @@ udevConnectListAllInterfaces(virConnectPtr conn, int tmp_count; int count = 0; int status = 0; - int ret; + int ret = -1; virCheckFlags(VIR_CONNECT_LIST_INTERFACES_FILTERS_ACTIVE, -1); @@ -320,7 +320,6 @@ udevConnectListAllInterfaces(virConnectPtr conn, virReportError(VIR_ERR_INTERNAL_ERROR, _("failed to get list of %s interfaces on host"), virUdevStatusString(status)); - ret = -1; goto cleanup; }