From fe52bc2638eebaaebcdae4c6d64c8125fd98736d Mon Sep 17 00:00:00 2001 From: Pavel Hrdina Date: Wed, 29 Sep 2021 18:53:52 +0200 Subject: [PATCH] qemu_snapshot: create: move virDomainSnapshotAssignDef to both code paths MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This makes it obvious that the function is called for creating new snapshot and redefining old snapshot as well. Signed-off-by: Pavel Hrdina Reviewed-by: Ján Tomko --- src/qemu/qemu_snapshot.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 6c09ab375e..abcee30116 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -1760,15 +1760,18 @@ qemuSnapshotCreateXML(virDomainPtr domain, driver->xmlopt, flags) < 0) goto endjob; + + if (!snap) { + if (!(snap = virDomainSnapshotAssignDef(vm->snapshots, def))) + goto endjob; + } } else { if (qemuSnapshotCreateAlignDisks(vm, def, driver, flags) < 0) goto endjob; if (qemuSnapshotPrepare(vm, def, &flags) < 0) goto endjob; - } - if (!snap) { if (!(snap = virDomainSnapshotAssignDef(vm->snapshots, def))) goto endjob;