External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

network: use virAsprintf when appropriate

Browse Source 
* src/conf/network_conf.c (virNetworkAllocateBridge): Avoid
limited buffer from snprintf.
This commit is contained in:
Eric Blake 2010-08-31 14:25:49 -06:00
parent ff578973c7
commit ff82941604
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/conf/network_conf.c
View File

@ -891,17 +891,14 @@ char *virNetworkAllocateBridge(const virNetworkObjListPtr nets,
template = "virbr%d"; template = "virbr%d";
do { do {
char try[50]; if (virAsprintf(&newname, template, id) < 0) {
virReportOOMError();
snprintf(try, sizeof(try), template, id); return NULL;
}
if (!virNetworkBridgeInUse(nets, try, NULL)) { if (!virNetworkBridgeInUse(nets, newname, NULL)) {
if (!(newname = strdup(try))) {
virReportOOMError();
return NULL;
}
return newname; return newname;
} }
VIR_FREE(newname);
id++; id++;
} while (id <= MAX_BRIDGE_ID); } while (id <= MAX_BRIDGE_ID);