External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

libxlMakeNetworkDiskSrc: Use virSecureEraseString instead of VIR_AUTODISPOSE_STR

Browse Source 
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Peter Krempa 2021-02-02 16:49:30 +01:00
parent 39089a6faf
commit ffc13e76ac
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/libxl/libxl_conf.c
View File

@ -999,7 +999,7 @@ static int
libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char **srcstr) libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char **srcstr)
{ {
virConnectPtr conn = NULL; virConnectPtr conn = NULL;
VIR_AUTODISPOSE_STR base64secret = NULL; g_autofree char *base64secret = NULL;
char *username = NULL; char *username = NULL;
int ret = -1; int ret = -1;
@ -1022,7 +1022,10 @@ libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char **srcstr)
virSecureErase(secret, secretlen); virSecureErase(secret, secretlen);
} }
if (!(*srcstr = libxlMakeNetworkDiskSrcStr(src, username, base64secret))) *srcstr = libxlMakeNetworkDiskSrcStr(src, username, base64secret);
virSecureEraseString(base64secret);
if (!*srcstr)
goto cleanup; goto cleanup;
ret = 0; ret = 0;