Jim Meyering
a178a4e7bf
Move safewrite and saferead to a separate file.
...
We currently use safewrite from inside libvirt and don't want to publish
any such function name. However, we do want to use it in applications
like virsh, libvirtd and libvirt_proxy that link with libvirt. To that
end, this change moves that function definition (along with the nearly
identical saferead) into a new file, util-lib.c. To avoid maintaining
separate copies of even such small functions, we simply include that new
file from util.c. Then, the separate applications that need to use
safewrite simply compile and link with util-lib.c.
Of course, this does mean that each of those applications will
containing two copies of these functions. However, the functions
are so small that it's not worth worrying about that.
* src/util.c (saferead, safewrite): Move function definitions to
util-lib.c and include that .c file.
* src/util-lib.c (saferead, safewrite): New file. Functions from src/util.c
with slight change (s/int r =/ssize_t r =/) to reflect read/write return type.
* src/util-lib.h: Declare the two moved functions.
* src/util.h: Remove declarations. Include src/util-lib.h.
* proxy/Makefile.am (libvirt_proxy_SOURCES): Add src/util-lib.c.
* qemud/Makefile.am (libvirtd_SOURCES): Likewise.
* src/Makefile.am (virsh_SOURCES): Add util-lib.c. Remove some SP-before-TAB.
2008-02-22 15:53:13 +00:00
Jim Meyering
6187c6de9b
With --enable-iptables-lokkit=no, avoid warning about unused parameter.
...
* src/iptables.c (iptRulesSave) [!ENABLE_IPTABLES_LOKKIT]:
Mark parameter as used.
2008-02-22 12:34:27 +00:00
Jim Meyering
bdbce64bab
With --without-xen, avoid warning about unused function.
...
* tests/statstest.c (testQuietError) [!WITH_XEN]: Don't define.
2008-02-22 12:33:47 +00:00
Jim Meyering
9bcade46df
Rewrite openvzSetUUID.
...
* src/openvz_conf.c (openvzSetUUID): Rewrite to avoid unchecked
lseek, write, and close as well as a potential file descriptor leak.
2008-02-21 18:48:06 +00:00
Jim Meyering
5fc07cd840
Handle failed openvzLocateConfDir.
...
* src/openvz_conf.c (openvzLocateConfDir, openvzGetVPSUUID):
(openvzSetUUID): Don't dereference NULL upon failure.
2008-02-21 18:22:45 +00:00
Richard W.M. Jones
be8653b183
Fix double-free in OpenVZ driver.
...
* src/openvz_conf.c: Double-free fix (Anton Protopopov).
2008-02-21 15:20:36 +00:00
Daniel P. Berrange
83d0aa0706
Added missing symbol export
2008-02-21 03:53:03 +00:00
Jim Meyering
c8c473c053
Avoid "make syntax-check" failure.
...
* docs/examples/index.py: Don't emit trailing blanks.
* docs/examples/Makefile.am: Regenerate.
2008-02-20 17:26:01 +00:00
Daniel P. Berrange
104cc98636
Update to work with new policy kit APIs
2008-02-20 16:54:35 +00:00
Daniel P. Berrange
caad8777e0
Update po files with latest translatable strings
2008-02-20 16:08:56 +00:00
Daniel P. Berrange
4bea16df64
Ignore libvirt_parthelper binary
2008-02-20 15:58:38 +00:00
Daniel P. Berrange
8b6b21d41c
Added docs on storage management capabilities
2008-02-20 15:58:06 +00:00
Daniel P. Berrange
a278dbb776
Ignore doc files for syntax check
2008-02-20 15:57:34 +00:00
Daniel P. Berrange
291158945d
Added no-op stub of storage APIs to test driver
2008-02-20 15:53:34 +00:00
Daniel P. Berrange
b49b628ab5
Added all example storage XML files
2008-02-20 15:52:40 +00:00
Daniel P. Berrange
b7db975135
Added disk partition storage pool backend
2008-02-20 15:52:17 +00:00
Daniel P. Berrange
8ec1fcd925
Added iSCSI storage pool backend
2008-02-20 15:49:25 +00:00
Daniel P. Berrange
049ff4e572
Set close-on-exec flag for signal pipe
2008-02-20 15:47:06 +00:00
Daniel P. Berrange
e266ded2f6
Added directory/filesystem/netfs based storage pool backend
2008-02-20 15:45:59 +00:00
Daniel P. Berrange
ac736602fd
Added logical volume storage pool driver
2008-02-20 15:45:33 +00:00
Daniel P. Berrange
e39438e869
Added directory/filesystem/netfs based storage pool backend
2008-02-20 15:42:30 +00:00
Daniel P. Berrange
4a4e272f9d
Added storage backend helper APIs
2008-02-20 15:38:29 +00:00
Daniel P. Berrange
20878720c0
Added main internal storage driver impl
2008-02-20 15:34:52 +00:00
Daniel P. Berrange
f43e709842
Added convenience virsh command for creating pools/volumes without XML
2008-02-20 15:29:13 +00:00
Daniel P. Berrange
816fd02876
Added virsh commands for storage management
2008-02-20 15:27:08 +00:00
Daniel P. Berrange
859679f72a
Added python binding for storage APIs
2008-02-20 15:26:22 +00:00
Daniel P. Berrange
661c5c4476
Add storage APIs to remote driver
2008-02-20 15:23:36 +00:00
Daniel P. Berrange
f48160cfb4
Add remote daemon support for storage APIs
2008-02-20 15:22:35 +00:00
Daniel P. Berrange
056da31bfe
Regenerate docs to include storage APIs
2008-02-20 15:20:44 +00:00
Daniel P. Berrange
cb228a0e24
Internal driver API for storage management
2008-02-20 15:06:53 +00:00
Daniel P. Berrange
e1d2e325dd
Add public API for storage management
2008-02-20 14:57:39 +00:00
Jim Meyering
26709f561f
Pull useless-if-before-free from gnulib, and update.
...
* bootstrap (gnulib_tool): Add useless-if-before-free to
the list of modules.
* build-aux/useless-if-before-free: Update from gnulib.
* gnulib/lib/vasnprintf.c: Work around a bug in HPUX 10.20.
* gnulib/m4/vasnprintf.m4: Likewise.
2008-02-13 21:52:19 +00:00
Daniel P. Berrange
e91aeae437
Ignore ChangeLog/NEWS file for whitespace checks
2008-02-12 14:45:17 +00:00
Daniel Veillard
fd71d295d7
Network doc example fixes
...
* docs/libvir.html docs/format.html: fixes the examples on the
section about ethernet bridging, as raised by Maxwell Bottiger,
fixes bug #430790
Daniel
2008-02-11 16:08:11 +00:00
Mark McLoughlin
3da5504e68
Fix gcc-4.3.0 "inlining failed" warning.
...
* src/internal.h: move xstrol() variants from here ...
* src/util.[ch]: ... to here and rename to virStrToLong()
* src/libvirt_sym.version: export __virStrToLong_i() for
virsh and qemud.
* src/nodeinfo.c, src/stats_linux.c, src/virsh.c,
src/xend_internal.c, qemud/qemud.c: replace xstrtol()
calls with virStrToLong()
* src/nodeinfo.h: don't include internal.h, which was only
needed for xstrtol(), but instead include libvirt.h which
is suffificient for the declarations in the header.
2008-02-08 09:15:16 +00:00
Jim Meyering
db4037e592
Enable another syntax-check rule.
...
* Makefile.cfg (local-checks-to-skip): Remove sc_no_have_config_h.
* qemud/mdns.c: Remove "#ifdef HAVE_CONFIG_H".
* Makefile.maint (sc_no_have_config_h): Tighten up regexp,
so that the above mention of "HAVE_CONFIG_H" doesn't match.
* .x-sc_no_have_config_h: New file, to exempt gnulib/ straggler.
2008-02-07 19:20:36 +00:00
Jim Meyering
3cb808d2a2
autobuild.sh: Run "make syntax-check", so the autobuilder does this.
2008-02-07 19:19:45 +00:00
Daniel Veillard
55f7de7821
missing ')'
...
* qemud/remote.c: fix a missing ')' introduced earlier
Daniel
2008-02-07 17:03:17 +00:00
Daniel Veillard
e9b3bc773d
virHashRemoveSet bugfixes
...
* src/hash.c: fix a couple of problems in virHashRemoveSet based
on Hiroyuki Kaguchi patch and explanations.
Daniel
2008-02-07 16:56:01 +00:00
Jim Meyering
247df6e448
Mark all qemudLog diagnostics for translation.
...
* po/POTFILES.in: Add names of many new files.
* Makefile.maint (err_func_re): Add qemudLog.
Mark diagnostics with _(...). Split some long lines.
* qemud/qemud.c (remoteCheckCertFile, remoteInitializeGnuTLS):
(qemudDispatchSignalEvent, qemudSetCloseExec, qemudSetNonBlock):
(qemudWritePidFile, qemudListenUnix, remoteMakeSockets):
(remoteListenTCP, qemudInitPaths, qemudInitialize):
(qemudNetworkInit, remoteInitializeTLSSession, remoteCheckDN):
(remoteCheckCertificate, remoteCheckAccess, qemudDispatchServer):
(qemudClientReadBuf, qemudDispatchClientRead):
(qemudClientWriteBuf, qemudDispatchClientWrite, qemudOneLoop):
(remoteConfigGetStringList, checkType, GET_CONF_STR):
(remoteConfigGetAuth, remoteReadConfigFile, main):
* qemud/remote.c (remoteDispatchAuthSaslInit, remoteSASLCheckSSF):
(remoteSASLCheckAccess, remoteDispatchAuthSaslStart):
(remoteDispatchAuthSaslStep, remoteDispatchAuthSaslInit):
(remoteDispatchAuthSaslStart, remoteDispatchAuthSaslStep):
(qemudGetSocketIdentity, remoteDispatchAuthPolkit):
* src/iptables.c (notifyRulesUpdated, MAX_FILE_LEN, iptRulesSave):
(iptRulesReload):
* src/qemu_conf.c (qemudExtractVersionInfo, qemudLoadConfig):
(qemudLoadNetworkConfig, qemudScanConfigDir):
* src/qemu_driver.c (qemudSetCloseExec, qemudSetNonBlock):
(qemudAutostartConfigs, qemudStartup, qemudReload):
(qemudWaitForMonitor, qemudStartVMDaemon, qemudVMData):
(qemudShutdownVMDaemon, qemudStartNetworkDaemon):
(qemudShutdownNetworkDaemon, qemudMonitorCommand):
(qemudDomainUndefine, qemudNetworkUndefine):
* src/uuid.c (virUUIDGenerate):
* src/xm_internal.c (xenXMAttachInterface):
2008-02-07 16:50:17 +00:00
Jim Meyering
e8ff93b4e6
Remove more useless if tests before "free"-like functions.
...
* build-aux/useless-if-before-free: Rename from ...
* build-aux/find-unnecessary-if-before-free: ... this. Remove file.
Also changed it so that new names are no longer hard-coded in the
script. Instead, they're supplied via options:
* Makefile.cfg (useless_free_options): Define.
Add xmlXPathFreeObject to the list of free-like functions it detects.
* Makefile.maint (sc_avoid_if_before_free): Reflect script renaming.
* .x-sc_avoid_if_before_free: Likewise.
* src/openvz_conf.c (openvzParseXML): Remove useless "if"-before-free.
* src/qemu_conf.c (qemudParseXML, qemudParseNetworkXML): Likewise.
* src/virsh.c (cmdVNCDisplay, cmdTTYConsole, cmdDetachInterface):
(cmdDetachDisk): Likewise.
* src/xm_internal.c (xenXMConfigSetIntFromXPath): Likewise.
(xenXMConfigSetStringFromXPath, xenXMParseXMLToConfig): Likewise.
(xenXMDomainAttachDevice, xenXMAttachDisk, xenXMAttachInterface):
(xenXMDomainDetachDevice): Likewise.
* src/xml.c (virXPathString): Likewise.
* tests/xmlrpctest.c (checkRequestValue): Likewise.
2008-02-07 16:49:29 +00:00
Jim Meyering
5a93214143
Remove trailing blanks
2008-02-07 12:34:19 +00:00
Mark McLoughlin
a0f83fd905
* src/xen_internal.c: Don't crash if there's no /sys/hypervisor/capabilities
2008-02-07 10:43:14 +00:00
Mark McLoughlin
3d3c8ac4c4
src/iptables.c: Create directory for saving iptables rules
2008-02-07 10:17:24 +00:00
Mark McLoughlin
f90cd4c3f4
src/xm_internal.[ch]: Move static function prototype from header
2008-02-07 10:14:43 +00:00
Daniel Veillard
ecaf98fcc5
Python bindings return values fixes
...
* python/libvir.c: apply patch from Cole Robinson to provide
return values for manulally written python bindings.
Daniel
2008-02-07 09:49:13 +00:00
Daniel Veillard
232d4f157a
Oops forgot >>>>, Daniel
2008-02-07 09:37:41 +00:00
Daniel Veillard
b33f740e1f
* src/libvirt.c: fix bug in xenUnifiedDomainSuspend() patch provided
...
by Marcus Meissner
Daniel
2008-02-07 09:37:10 +00:00
Daniel Veillard
594af3eb22
add/change/delete a Disk/NIC of an inactive domains
...
* src/xm_internal.[ch]: applied patch from Shigeki Sakamoto to
add/change/delete a Disk/NIC of an inactive domains
Daniel
2008-02-06 17:57:10 +00:00
Daniel Veillard
eecd68364a
QEmu config error handling fixes
...
* src/qemu_conf.c: applied 2 patches from Guido Guenther to avoid
crashes when reading the config file
Daniel
2008-02-06 16:24:28 +00:00