3 Commits

Author	SHA1	Message	Date
Daniel P. Berrangé	1fb73537d7	Fix header ifdef check for config-post.h in VPATH build ... We must do a substring match, not an exact match since there can be an arbitrary virtual path prepended. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>	2018-12-14 14:08:51 +00:00
Daniel P. Berrangé	568a417224	Enforce a standard header file guard symbol name ... Require that all headers are guarded by a symbol named LIBVIRT_$FILENAME where $FILENAME is the uppercased filename, with all characters outside a-z changed into '_'. Note we do not use a leading __ because that is technically a namespace reserved for the toolchain. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>	2018-12-14 10:47:13 +00:00
Daniel P. Berrangé	4cfd709021	Fix many mistakes & inconsistencies in header file layout ... This introduces a syntax-check script that validates header files use a common layout: /* ...copyright header... */ <one blank line> #ifndef SYMBOL # define SYMBOL ....content.... #endif /* SYMBOL */ For any file ending priv.h, before the #ifndef, we will require a guard to prevent bogus imports: #ifndef SYMBOL_ALLOW # error .... #endif /* SYMBOL_ALLOW */ <one blank line> The many mistakes this script identifies are then fixed. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>	2018-12-14 10:46:53 +00:00