Daniel P. Berrange
0420a03240
Remove use of getuid()==0 for privilege checks
2009-06-12 13:20:13 +00:00
Daniel Veillard
e11013d19c
* src/network_driver.c: forbid set Autostart on transcient networks
...
daniel
2009-06-03 13:52:06 +00:00
Cole Robinson
b121c7871f
network driver: Fix regression defining colliding networks at daemon startup.
...
If two virtual networks have the same hardcoded bridge device (which
prevents them from being active simultaneously) we still want to define
them at daemon startup, so the user has a fighting chance of correcting
the XML error.
Add an extra flag to SetBridge to avoid reporting an error if there is
a bridge collision, and use this when loading network configs at startup.
This regressed via commit 4c3f3b4d
2009-05-29 14:18:57 +00:00
Cole Robinson
545c815c4c
networkDestroy: Report error if network is inactive
...
This follows the same convention as domain drivers.
2009-05-29 14:14:32 +00:00
Daniel Veillard
e8da987570
cleanup of some direct stderr logging
...
* qemud/qemud.c src/console.c src/network_driver.c
src/node_device_conf.c src/node_device_hal.c src/storage_conf.c
src/util.c: cleanup of some direct stderr logging
daniel
2009-05-20 13:37:30 +00:00
Daniel P. Berrange
de658ab4e4
Fix misc locking bugs identified by lock checker
2009-05-19 11:06:25 +00:00
Daniel Veillard
e978774ec6
* src/network_driver.c: enable bridges which are not up
...
without an IP address, patch by Ludwig Nussel
Daniel
2009-05-12 15:31:22 +00:00
Cole Robinson
1f11e3bb61
Generate network bridge names if none passed at define/create time.
2009-03-02 17:37:03 +00:00
Cole Robinson
895247b76b
Mark 'defined' networks as persistent.
2009-03-02 17:29:44 +00:00
Mark McLoughlin
761f5a52dc
networkEnableIpForwarding() now returns zero for success
2009-02-22 11:19:54 +00:00
Mark McLoughlin
0bb6f816e3
Add virFileWriteStr()
...
Re-factor the code from networkEnableIpForwarding() into a
utility function in preparation for code which writes to
sysfs files.
2009-02-13 19:13:06 +00:00
Jim Meyering
bafd7389e4
remove remainder of offending strerror uses
...
* qemud/qemud.c (GET_CONF_STR): Use virStrerror, not strerror.
* qemud/remote.c (remoteDispatchDomainBlockPeek): Likewise.
(remoteDispatchDomainMemoryPeek, remoteDispatchAuthSaslInit): Likewise.
(remoteDispatchAuthPolkit): Likewise.
* src/lxc_container.c (lxcContainerAvailable): Likewise.
* src/network_driver.c (networkStartNetworkDaemon): Likewise.
(networkShutdownNetworkDaemon): Likewise.
* src/qemu_conf.c (qemudExtractVersion, qemudNetworkIfaceConnect):
* src/storage_conf.c (virStoragePoolLoadAllConfigs): Likewise.
* src/storage_driver.c (storagePoolUndefine): Likewise.
* src/uml_driver.c (umlStartup, umlStartVMDaemon): Likewise.
* src/util.c (virFileReadAll): Likewise.
* src/uuid.c (virUUIDGenerate): Likewise.
* src/xen_internal.c (get_cpu_flags): Likewise.
2009-02-05 16:28:30 +00:00
Jim Meyering
bc18a91f91
error-reporting calls using VIR_ERR_NO_MEMORY: use virReportOOMError instead
...
* src/uml_conf.c (VIR_FROM_THIS): Define to VIR_FROM_UML.
* src/xs_internal.c (VIR_FROM_THIS): Define to VIR_FROM_XEN.
* src/xml.c (VIR_FROM_THIS): Define to VIR_FROM_XML.
* src/stats_linux.c (VIR_FROM_THIS): Define to VIR_FROM_STATS_LINUX.
* src/datatypes.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/lxc_conf.c (VIR_FROM_THIS): Define to VIR_FROM_LXC.
* src/libvirt.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/node_device_conf.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/openvz_conf.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/openvz_driver.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/conf.c (VIR_FROM_THIS): Define to VIR_FROM_CONF.
Note: this loses config_filename:config_lineno diagnostics,
but that's ok.
* src/node_device.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/sexpr.c (VIR_FROM_THIS): Define to VIR_FROM_SEXPR.
* po/POTFILES.in: remove src/sexpr.c and src/lxc_conf.c
2009-01-29 12:10:32 +00:00
Daniel P. Berrange
1b745219c7
Remove use of non-reentrant POSIX apis
2009-01-22 19:41:48 +00:00
Daniel P. Berrange
23a090ab92
Allow virtual networks to survive daemon restart
2009-01-20 22:36:10 +00:00
Jim Meyering
3548e9aae8
don't ignore write failure
...
* src/network_driver.c (networkEnableIpForwarding): This function
would always return 1 (success). Now it returns 0 upon write or
close failure, being careful to preserve any errno from a write failure.
Add comments.
2009-01-20 19:29:08 +00:00
Daniel P. Berrange
437ac354fc
Make error reporting threadsafe by avoiding strerror
2009-01-20 17:13:33 +00:00
Daniel P. Berrange
4dac0a1105
Generic internal threads API
2009-01-15 19:56:05 +00:00
Guido Günther
043d702f02
use virAsprintf instead of asprintf
2008-12-23 13:03:29 +00:00
Cole Robinson
52037657dc
Fix segfault if virtual network does not have a bridge name
2008-12-11 14:57:45 +00:00
Daniel P. Berrange
bff6ac7b63
Add locking for thread safety to network driver
2008-12-04 21:38:38 +00:00
Daniel P. Berrange
b6dbbdc9fe
Merge all return paths from network driver APIs
2008-12-04 21:37:52 +00:00
Daniel P. Berrange
618276de19
Push URI probing logic down into individual drivers
2008-11-17 11:44:51 +00:00
Daniel P. Berrange
6ace5a39c3
Move some API declarations out of internal.h & hash.c into dedicated files
2008-11-04 23:22:06 +00:00
Daniel P. Berrange
2f19b24a03
Remove unused internal virStateSigDispatcher() API
2008-11-04 22:55:51 +00:00
Daniel P. Berrange
d714b2afae
Move internal error APIs into virterror_internal.h & drop leading __ prefix
2008-11-04 22:30:33 +00:00
Chris Lalancette
c83c3e9e5c
While doing on this patch series, I mistakenly added a bogus piece of
...
storage XML to libvirtd, which was saved in /etc/libvirt/storage. On subsequent
stop/start of libvirtd, because of another bug , an
error wasn't being set properly in an error path, so libvirtd was SEGV'ing in
storage_conf.c:virStoragePoolObjLoad when trying to dereference the NULL err
returned from virGetLastError(). Make this more robust against errors by always
doing "err ? err->message : NULL" in the printf. I looked around the tree and
found a couple of other places that weren't guarded, so this patch fixes them as
well.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-21 17:15:53 +00:00
Chris Lalancette
0fd0cb6037
"make syntax-check" was complaining that network_driver.c was missing from
...
POTFILES.in. Add it there, and then fix up one warning about included
c-ctypes.h that wasn't being used.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-16 12:04:06 +00:00
Daniel P. Berrange
dd48e929c7
Switch network objects to array instead of linked list
2008-10-10 14:50:26 +00:00
Daniel P. Berrange
1564711a27
Split network driver out into separate files
2008-10-10 13:57:13 +00:00
