External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-23 13:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
48,410 Commits 67 Branches 632 Tags
Commit Graph

34489 Commits

Author SHA1 Message Date
Michal Privoznik
58b7cafc28 virauth: Report error on empty auth result 
When opening a connection, it may be necessary to provide user
credentials, or some additional info (e.g. whether to trust an
ssh key). We have a special API for that: virConnectOpenAuth()
where and additional callback can be passed. This callback is
then called with _virConnectCredential struct filled partially
and it's callback's responsibility to get desired data (e.g. by
prompting user) and store it into .result member of the struct.

But we document the callback behaviour as:

  When authentication requires one or more interactions, this callback
  is invoked. For each interaction supplied, data must be gathered
  from the user and filled in to the 'result' and 'resultlen' fields.
  If an interaction cannot be filled, fill in NULL and 0.

  Returns 0 if all interactions were filled, or -1 upon error

But there are some buggy callbacks out there, which set:

  .result = NULL;
  .resultlen = 0;

and return 0. Report an error when such buggy callback is met.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2181235
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
 2023-04-03 08:34:53 +02:00
Jiri Denemark
90d8652438 src: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
72bcbcfef9 vz: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
c7dbe9c93d vmx: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
9d10e31258 vmware: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
7d2d1cc705 vbox: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
b32bbe1e60 util: Update format strings in translated messages (part 3) 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
f0ed4de9ec util: Update format strings in translated messages (part 2) 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
e349cdc54b util: Update format strings in translated messages (part 1) 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
b3a5d1f1dc test: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
74f4547c47 storage_file: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
ce0c2010a8 storage: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:35 +02:00
Jiri Denemark
181d61fd5c secret: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
798bf7588c security: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
88af62f6a0 rpc: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
732ff069ad remote: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
71b19c4f08 qemu: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
21833b5564 qemu/qemu_validate: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
49f2835ee3 qemu/qemu_process: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
6d6f072e4b qemu/qemu_monitor_json: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
d5abf94073 qemu/qemu_migration: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
030a14679b qemu/qemu_hotplug: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
042c94220c qemu/qemu_driver: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:34 +02:00
Jiri Denemark
27ed822d30 qemu/qemu_domain: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
9c6fc8b555 qemu/qemu_command: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
1d4a4f21ce openvz: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
04df8f474b nwfilter: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
6b8763675d node_device: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
0f96ac3d2c network: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
322dd93901 lxc: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
0121243d67 logging: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
3d61757c3b locking: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
8875aee4eb libxl: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
be664663fa interface: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
1d279b0abd hypervisor: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:33 +02:00
Jiri Denemark
7d8f371801 hyperv: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
e9616d9786 esx: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
e0fd806363 cpu: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
5f354d5cc0 conf: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
0df355c6ba conf/node_device_conf: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
772316c8df conf/network_conf: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
b908a3b0bb conf/domain_validate: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
d4d01dcb92 conf/domain_conf: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
187a94b97b ch: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
4cae4cd40e bhyve: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
044ec5f7d2 admin: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:32 +02:00
Jiri Denemark
a1f8154b3d access: Update format strings in translated messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
 2023-04-01 11:40:31 +02:00
Jiri Denemark
6ad1f3c701 Do not use VIR_PCI_DEVICE_ADDRESS_FMT in translations 
xgettext cannot handle strings concatenated with cpp macros.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2023-04-01 09:58:17 +02:00
Jiri Denemark
dc65e253fe Drop excess whitespace from error messages 
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2023-04-01 09:58:17 +02:00
Peter Krempa
0bfd11dd85 conf: Clear pointer to freed bitmap holding hostdev's 'origstates' 
'virDomainHostdevDefClear' must clear the pointers too as it can be
invoked multiple times on the same object e.g. inside
qemuDomainRemoveHostDevice once via virDomainHostdevDefFree which skips
freeing the object if it's used via <interface> and thus has a 'net'
definition corresponding to it, and then subsequently via
virDomainNetDefFree.

Fix it by clearing the pointer along with freeing it.

Fixes: d9e4075d4e9
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2182961
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2023-03-30 15:17:08 +02:00