Daniel P. Berrange
40a82f3066
Make QEMU test suite independant of host OS capabilities
2008-05-16 16:51:30 +00:00
Jim Meyering
a770c2ab1c
* src/xml.c: Include "c-ctype.h".
2008-05-16 14:18:38 +00:00
Jim Meyering
c1ee35af3b
start using c-ctype functions
...
Up to now, we've been avoiding ctype functions like isspace, isdigit,
etc. because they are locale-dependent. Now that we have the c-ctype
functions, we can start using *them*, to make the code more readable
with changes like these:
- /* This may not work on EBCDIC. */
- if ((*p >= 'a' && *p <= 'z') ||
- (*p >= 'A' && *p <= 'Z') ||
- (*p >= '0' && *p <= '9'))
+ if (c_isalnum(*p))
- while ((*cur >= '0') && (*cur <= '9')) {
+ while (c_isdigit(*cur)) {
Also, some macros in conf.c used names that conflicted with
standard meaning of "BLANK" and "SPACE", so I've adjusted them
to be in line with the definition of e.g., isblank.
In addition, I've wrapped those statement macros with do {...} while (0),
so that we can't forget the ";" after a use. There was one like that
already (fixed below). The missing semicolon would mess up automatic
indenting.
* src/buf.c (virBufferURIEncodeString):
* src/conf.c (IS_EOL, SKIP_BLANKS_AND_EOL, SKIP_BLANKS)
(virConfParseLong, virConfParseValue, virConfParseName)
(virConfParseSeparator, virConfParseStatement, IS_BLANK, IS_CHAR)
(IS_DIGIT, IS_SPACE, SKIP_SPACES):
* src/nodeinfo.c:
* src/qemu_conf.c (qemudParseInterfaceXML):
* src/qemu_driver.c (qemudDomainBlockStats):
* src/sexpr.c:
* src/stats_linux.c:
* src/util.c (virParseNumber, virDiskNameToIndex):
* src/uuid.c (hextobin, virUUIDParse):
* src/virsh.c:
* src/xml.c (parseCpuNumber, virParseCpuSet):
2008-05-16 09:37:44 +00:00
Jim Meyering
0dc23afb0c
avoid a double-free bug
...
* src/qemu_conf.c (qemudParseXML): Ensure that "obj" is either
NULL or a valid malloc'd pointer before we might "goto error"
where it is freed.
2008-05-16 09:30:10 +00:00
Daniel P. Berrange
65c2738ea1
Remove use of strcmp()
2008-05-15 20:07:34 +00:00
Daniel P. Berrange
25f860dc2f
Fixe default disk bus selection logic
2008-05-15 16:24:26 +00:00
Daniel P. Berrange
763a59d84d
Support Xenner bootloader
2008-05-15 16:21:11 +00:00
Daniel P. Berrange
0f1b6dd06a
Pass -name arg to QEMU when available
2008-05-15 16:15:17 +00:00
Daniel P. Berrange
3a7b528d4b
Add support for Xen input device in QEMU driver for xenner
2008-05-15 16:11:40 +00:00
Daniel P. Berrange
2c37f47985
Support paravirt disk configuration for xenner guests
2008-05-15 16:05:41 +00:00
Jim Meyering
6049594045
avoid using STREQLEN with a literal; use STRPREFIX instead
...
Likewise for STRNEQLEN -> !STRPREFIX.
* src/nodeinfo.c (linuxNodeInfoCPUPopulate):
* src/qemu_conf.c (qemudNetworkIfaceConnect):
(qemudParseInterfaceXML):
* src/qemu_driver.c (qemudDomainBlockStats):
* src/remote_internal.c (call):
* src/stats_linux.c (xenLinuxDomainDeviceID):
* src/xend_internal.c (xend_parse_sexp_desc):
(xend_get, sexpr_to_xend_topology):
* src/xm_internal.c (xenXMConfigCacheRefresh)
(xenXMDomainFormatXML):
2008-05-15 14:21:34 +00:00
Jim Meyering
abb9a583a0
* Makefile.maint (sc_prohibit_strcmp): Also prohibit strncmp.
2008-05-15 07:12:43 +00:00
Atsushi SAKAI
b87f3000aa
Change libvirtd description from qemu only to various VM(i.e. Xen, LXC)
...
Fix typos and comments
2008-05-15 06:12:32 +00:00
Jim Meyering
13555de861
exempt gnulib/ from "make syntax-check" strcmp prohibition
...
* .x-sc_prohibit_strcmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp.
2008-05-14 21:18:27 +00:00
Daniel P. Berrange
f7fe78dc82
Added listen_addr config param for daemon (Stefan de Konink)
2008-05-14 20:57:20 +00:00
Daniel P. Berrange
1d73398e8f
Remove all use of strcmp, strncmp in favour of STREQ, STREQLEN, STRPREFIX
2008-05-14 19:51:24 +00:00
Jim Meyering
e830d52573
avoid "not a string literal..." warnings
...
* src/qemu_conf.c (qemudParseInterfaceXML): Add "%s".
(qemudBuildCommandLine, qemudGenerateXML): Likewise.
2008-05-13 09:15:11 +00:00
David L. Leskovec
773d59e86d
Fix some stray leading spaces in Changelog entry for my last commit
2008-05-13 06:51:42 +00:00
David L. Leskovec
94311de539
Enable libvirtd drivers to handle signals, in lxc, sigchld triggers vm cleanup
...
Mon May 12 23:32:21 PST 2008 David L. Leskovec <dlesko@linux.vnet.ibm.com>
* qemud/qemud.c: get siginfo with signals, distribute to drivers that
register a handler
* src/driver.h: add sighandler function to state driver table
* src/internal.h: define virStateSigDispatcher functions
* src/libvirt.c: add __virStateSigDispatcher function
* src/libvirt_sym.version: add __virStateSigDispatcher
* src/lxc_driver.c: add sig handler function, cleanup vm when sigchld
received from container process
* src/qemu_driver.c: NULL for sig handler (no handler) in state driver
* src/remote_internal.c: NULL for sig handler (no handler) in state driver
* src/storage_driver.c: NULL for sig handler (no handler) in state driver
2008-05-13 06:30:58 +00:00
Daniel P. Berrange
098ba1a433
Add support for -drive QEMU syntax, and virtio bus / disk type
2008-05-09 16:41:19 +00:00
Jim Meyering
7967662a52
Add new files from gnulib.
...
* gnulib/lib/c-ctype.c: New file.
* gnulib/lib/c-ctype.h: Likewise.
* gnulib/tests/test-c-ctype.c: Likewise.
* gnulib/tests/test-vc-list-files-git.sh: Likewise.
* gnulib/tests/test-vc-list-files-cvs.sh: Likewise.
2008-05-09 14:03:15 +00:00
Jim Meyering
25534052bc
Use gnulib's c-ctype.h, not <ctype.h>.
...
# Convert uses of isspace to c_isspace, isdigit to c_isdigit, etc.
re=$(man isspace|grep is.....,.is|sed 's/ -.*//' \
|tr -s ', \n' \||sed 's/^|//;s/|$//')
git grep -l -E "$re"|grep -Ev 'Chan|gnulib' \
|xargs perl -pi -e 's/\b('"$re"')\b/c_$1/g'
# Remove all uses of to_uchar
git grep -l to_uchar|xargs perl -pi -e 's/to_uchar\((.*?)\)/$1/g'
* src/util.h (to_uchar): Remove definition.
(TOLOWER): Remove definition.
(__virMacAddrCompare): Use c_tolower, not TOLOWER.
Globally:
Where needed, change <ctype.h> to <c-ctype.h>.
Remove unnecessary inclusion of <ctype.h>.
Ensure the global changes are never needed again:
* Makefile.maint (sc_avoid_ctype_macros): Prohibit use of ctype
macros. Recommend c-ctype.h instead.
(sc_prohibit_c_ctype_without_use): New rule.
(sc_prohibit_ctype_h): New rule. Disallow use of <ctype.h>.
2008-05-09 13:50:14 +00:00
Jim Meyering
82892f131b
Prepare to use gnulib's c-type module.
...
* bootstrap: Move module list into separate variable w/less syntax.
(modules): Add c-ctype.
Update the following from gnulib:
* build-aux/useless-if-before-free:
* build-aux/vc-list-files:
* gnulib/lib/Makefile.am:
* gnulib/lib/getaddrinfo.h:
* gnulib/m4/gnulib-cache.m4:
* gnulib/m4/gnulib-comp.m4:
* gnulib/m4/inet_ntop.m4:
* gnulib/tests/Makefile.am:
* gnulib/tests/test-getaddrinfo.c:
2008-05-09 13:46:09 +00:00
Daniel Veillard
5e1bd04692
autostart for running Xen domains
...
* src/xen_unified.c src/xend_internal.c src/xend_internal.h: patch
from Cole Robinson implementing autostart for running Xen domains
Daniel
2008-05-09 08:17:18 +00:00
Jim Meyering
eb046f9d59
sytnax-check: add a check for risky ctype macro use
...
* Makefile.maint (sc_risky_ctype_macros): New rule.
2008-05-09 08:11:13 +00:00
Jim Meyering
b8111adf35
avoid one more ctype vs. sign-extension problem
...
* src/util.c (TOLOWER): Also convert tolower argument.
2008-05-09 08:09:48 +00:00
Jim Meyering
712251009b
add "const" and "static" attributes to file-scoped globals
...
* src/storage_backend_fs.c (fileTypeInfo): Add "static" and two
"const" attributes.
(FileTypeInfo): Name the previously anonymous struct,
so the declaration of fileTypeInfo looks more conventional.
* src/xend_internal.c (sound_models): Mark as static, and
as an array of "const" entries.
These were relatively new additions to the list from here:
nm src/*.o|grep ' D '
2008-05-09 08:02:44 +00:00
David L. Leskovec
6ca76333f3
*** empty log message ***
2008-05-09 07:16:30 +00:00
Daniel P. Berrange
d9691ab277
Added some notes about libvirt string/memory/buffer functions
2008-05-08 14:49:53 +00:00
Daniel P. Berrange
021bd31706
Added disk target bus type to Xen driver
2008-05-08 14:41:56 +00:00
Daniel P. Berrange
979edb4a64
Update domain XML docs
2008-05-08 14:20:07 +00:00
Daniel P. Berrange
7b21582e2d
Fix polkit docs
2008-05-08 11:52:21 +00:00
Daniel P. Berrange
31b17e6d44
Disable sound functions when in proxy
2008-05-07 18:50:23 +00:00
Daniel Veillard
da6316f20e
SetVcpus and DomainGetMaxVcpus for QEmu
...
* src/qemu_conf.c src/qemu_conf.h src/qemu_driver.c: another patch
from Cole Robinson adding SetVcpus and DomainGetMaxVcpus for QEmu
Daniel
2008-05-07 16:16:44 +00:00
Daniel Veillard
0feb4c9552
More regression tests for sound support
...
* tests/qemuxml2argvdata/qemuxml2argv-sound.args
tests/qemuxml2argvdata/qemuxml2argv-sound.xml
tests/sexpr2xmldata/sexpr2xml-fv-sound-all.sexpr
tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml
tests/sexpr2xmldata/sexpr2xml-fv-sound.sexpr
tests/sexpr2xmldata/sexpr2xml-fv-sound.xml
tests/xmconfigdata/test-fullvirt-sound.cfg
tests/xmconfigdata/test-fullvirt-sound.xml
tests/xml2sexprdata/xml2sexpr-fv-sound.sexpr
tests/xml2sexprdata/xml2sexpr-fv-sound.xml: other regression
tests from previous commit
Daniel
2008-05-07 14:44:20 +00:00
Daniel Veillard
70f446631f
Sound support for QEmu and Xen
...
* src/qemu_conf.c src/qemu_conf.h src/xend_internal.c
src/xend_internal.h src/xm_internal.c src/xml.c src/xml.h:
Patch from Cole Robinson adding sound support for QEmu and Xen
* tests/qemuxml2argvtest.c tests/sexpr2xmltest.c
tests/xmconfigtest.c tests/xml2sexprtest.c:
Associated regression tests
Daniel
2008-05-07 14:04:40 +00:00
Daniel P. Berrange
2afd1db4a2
Fix build on F9 with missing stddefs.h include
2008-05-06 21:44:12 +00:00
Jim Meyering
924e953f47
* build-aux/vc-list-files: Add support for bzr.
...
Author: Soren Hansen <soren@ubuntu.com>
2008-05-06 21:23:20 +00:00
Daniel P. Berrange
db3f10c807
Check in /usr/sbin for iptables too, for SUSE distros (Jim Fehlig)
2008-05-05 19:58:56 +00:00
Daniel P. Berrange
b04e40d6a3
Remove bogus check for NULL in qparams breaking connections
2008-05-01 18:11:03 +00:00
Daniel P. Berrange
3bc5510a63
Remove compat macros now present in onceonly.m4
2008-04-30 16:32:26 +00:00
Jim Meyering
07efaf941f
update from gnulib, again
...
* gnulib/m4/onceonly.m4: New file.
* gnulib/m4/printf.m4: New file.
* build-aux/useless-if-before-free: Update.
* build-aux/vc-list-files: Update.
* gnulib/lib/arpa_inet.in.h: Update.
* gnulib/lib/stdio-impl.h: Update.
* gnulib/m4/inet_ntop.m4: Update.
2008-04-30 16:11:08 +00:00
Daniel P. Berrange
a9420c223e
Add compat for RHEL-5 autoconf
2008-04-30 15:54:40 +00:00
Daniel P. Berrange
159cb2b97c
Added support for network interface model setting
2008-04-30 12:30:55 +00:00
Jim Meyering
303277a8dc
* gnulib/lib/stdio-impl.h: Add another new file from gnulib.
2008-04-29 21:43:50 +00:00
Jim Meyering
eb6c33cd97
* gnulib/tests/test-EOVERFLOW.c: Add another new file from gnulib.
2008-04-29 21:39:38 +00:00
Jim Meyering
ffdc37c2aa
Fix build errors.
...
* proxy/Makefile.am (libvirt_proxy_LDADD): Add ../gnulib/lib/libgnu.la.
* gnulib/lib/arpa_inet.in.h: Add new file from gnulib.
2008-04-29 21:23:34 +00:00
Jim Meyering
130426c659
update from gnulib
...
* gnulib/lib/inet_ntop.h: Remove file.
* gnulib/m4/onceonly_2_57.m4: Remove file.
* build-aux/useless-if-before-free: Update.
* build-aux/vc-list-files: Update.
* gnulib/lib/.cvsignore: Update.
* gnulib/lib/Makefile.am: Update.
* gnulib/lib/fseeko.c: Update.
* gnulib/lib/getaddrinfo.c: Update.
* gnulib/lib/getdelim.c: Update.
* gnulib/lib/inet_ntop.c: Update.
* gnulib/lib/inet_ntop.h: Update.
* gnulib/lib/poll.c: Update.
* gnulib/lib/snprintf.c: Update.
* gnulib/lib/stdlib.in.h: Update.
* gnulib/lib/string.in.h: Update.
* gnulib/lib/sys_socket.in.h: Update.
* gnulib/lib/sys_stat.in.h: Update.
* gnulib/lib/vasnprintf.c: Update.
* gnulib/lib/vasprintf.c: Update.
* gnulib/lib/wchar.in.h: Update.
* gnulib/m4/arpa_inet_h.m4: Update.
* gnulib/m4/extensions.m4: Update.
* gnulib/m4/gnulib-common.m4: Update.
* gnulib/m4/gnulib-comp.m4: Update.
* gnulib/m4/include_next.m4: Update.
* gnulib/m4/inet_ntop.m4: Update.
* gnulib/m4/netinet_in_h.m4: Update.
* gnulib/m4/onceonly_2_57.m4: Update.
* gnulib/m4/physmem.m4: Update.
* gnulib/m4/snprintf.m4: Update.
* gnulib/m4/stdint.m4: Update.
* gnulib/m4/stdio_h.m4: Update.
* gnulib/m4/stdlib_h.m4: Update.
* gnulib/m4/string_h.m4: Update.
* gnulib/m4/strndup.m4: Update.
* gnulib/m4/sys_select_h.m4: Update.
* gnulib/m4/sys_socket_h.m4: Update.
* gnulib/m4/sys_stat_h.m4: Update.
* gnulib/m4/vasnprintf.m4: Update.
* gnulib/tests/Makefile.am: Update.
* gnulib/tests/test-fseeko.c: Update.
* gnulib/tests/test-getaddrinfo.c: Update.
* gnulib/tests/test-getdelim.c: Update.
* gnulib/tests/test-getline.c: Update.
* gnulib/tests/test-lseek.c: Update.
* gnulib/tests/test-snprintf.c: Update.
* gnulib/tests/test-sys_stat.c: Update.
* gnulib/tests/test-vasnprintf.c: Update.
* gnulib/tests/test-vasprintf.c: Update.
2008-04-29 19:52:26 +00:00
Jim Meyering
0c37f59802
remove useless tests before xmlFree
...
* src/qemu_conf.c (qemudParseDiskXML, qemudParseInterfaceXML):
(qemudParseInputXML, qemudParseDhcpRangesXML):
* src/remote_internal.c (doRemoteOpen):
* src/storage_conf.c (virStoragePoolDefParseDoc):
* src/xm_internal.c (xenXMParseXMLDisk, xenXMParseXMLVif):
(xenXMParseXMLToConfig, xenXMAttachInterface):
* src/xml.c (virDomainParseXMLDiskDesc, virDomainParseXMLIfDesc):
(virDomainXMLDevID):
2008-04-29 19:43:57 +00:00
Daniel P. Berrange
e9c7af6864
Tell gcov to look in .libs to find coverage data
2008-04-29 15:41:30 +00:00