Daniel P. Berrange
2d6adabd53
Don't blindly reorder disk drives
...
Calling qsort() on the disks array causes disk to be
unneccessarily re-ordered, potentially breaking the
ability to boot if the boot disk gets moved later in
the list. The new algorithm will insert a new disk as
far to the end of the list as possible, while being
ordered correctly wrt other disks on the same bus.
* src/domain_conf.c, src/domain_conf.h: Remove disk sorting
routines. Add API to insert a disk into existing list at
the optimal position, without resorting disks
* src/libvirt_private.syms: Export virDomainDiskInsert
* src/xend_internal.c, src/xm_internal.c: Remove calls to
qsort, use virDomainDiskInsert instead.
* src/qemu_driver.c: Remove calls to qsort, use virDoaminDiskInsert
instead. Fix reordering bugs when hotunplugging disks and
networks. Fix memory leak in disk/net unplug
2009-09-02 15:19:34 +01:00
Chris Lalancette
48de890392
Remove a duplicated assignment in Xen PCI parsing.
...
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2009-08-11 13:32:50 +02:00
Chris Lalancette
09cbae6297
Fix up a few minor indentation issues.
...
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2009-08-11 13:32:26 +02:00
Daniel P. Berrange
acec6c3d02
Avoid a warning if compiling without inotify
...
* src/xm_internal.c: split the implementations of xenInotifyActive()
2009-08-05 12:04:26 +02:00
Cole Robinson
a11010c07d
Refresh /etc/xen if inotify wasn't
...
* src/xm_internal.c: in case of multiple connections to the xen driver
and some clients were not using domain events, the whole /etc/xen
monitoring would break leading to disapearing domains.
2009-08-05 11:46:33 +02:00
Cole Robinson
8ddfb40e2d
Don't loose id on xen domain redefine
...
* src/xm_internal.c: bug when redefining a domain, if it was running
we would loose its id
2009-08-05 11:39:31 +02:00
Daniel Veillard
144276aa1a
extend the configuration parser for VMX syntax
...
* qemud/qemud.c src/conf.c src/conf.h src/qemu_conf.c src/xen_unified.c
src/xm_internal.c tests/conftest.c tests/xmconfigtest.c: extend
the configuration parser for VMX syntax, patch by Matthias Bolte
Daniel
2009-06-19 12:34:30 +00:00
Daniel Veillard
f969e393a9
Fix a memory error on Xen device removal
...
* src/xm_internals.c: the memory shrinking on device removal
didn't copy the right amount of memory, patch by Daniel Berrange
fixes #497051
daniel
2009-06-04 13:56:49 +00:00
Daniel Veillard
7ee54d8356
Changes needed for multiple graphics adapters
...
* src/domain_conf.c src/domain_conf.h: parse and save multiple
graphics elements instead of one, patch by Pritesh Kothari
* src/qemu_conf.c src/qemu_driver.c: adapt the qemu/kvm driver for
the new structures, patch by Pritesh Kothari
* src/xend_internal.c src/xm_internal.c: same thing for Xen drivers
Daniel
2009-05-07 07:27:49 +00:00
Daniel P. Berrange
1fbee8dadf
Fix XM driver VIF config creation
2009-04-24 12:17:50 +00:00
Daniel Veillard
14687aad81
* src/xm_internal.c: fix a crash on vcpupin to inactive Xen domains,
...
as raised by Takahashi Tomohiro
daniel
2009-04-15 09:53:34 +00:00
Daniel P. Berrange
e4073623a6
Support PCI passthrough for Xen
2009-04-03 12:38:52 +00:00
Daniel P. Berrange
b02c0455d1
Fix localtime handling for newer XenD
2009-04-01 10:36:52 +00:00
Daniel P. Berrange
83a618f807
Add support for vifname= in XM config files
2009-04-01 10:16:05 +00:00
Daniel P. Berrange
3ad8a273b5
Improve error reporting in Xen driver SEXPR generation
2009-04-01 10:01:23 +00:00
Chris Lalancette
4d3d0039e5
Convert all drivers to use old-style struct initializers; this makes a handy
...
built-in TODO list for each driver. Also rip out the internal getURI method;
it is never used by any of the drivers, and was buggy to boot.
2009-03-31 15:47:16 +00:00
Daniel P. Berrange
97230f6a35
Default to native arch, and check domain type when auto-filling guest arch (Soren Hansen)
2009-03-24 11:16:29 +00:00
Jim Meyering
a9aa76bad5
remove useless code
...
* src/bridge.c (brAddTap): Remove redundant errno=ENOMEM assignment
after failed strdup.
* src/cgroup.c (virCgroupFree): Remove redundant *group=NULL assignment
after VIR_FREE(*group).
* src/lxc_driver.c (lxcShutdown): Likewise.
* src/xen_unified.c (xenUnifiedClose): Likewise.
* src/xm_internal.c (xenXMDomainConfigFormat): Rewrite disk-
and net-config-setting code to be clearer.
2009-02-05 16:03:11 +00:00
John Levon
e80f10064e
parse IP address for bridge interfaces
2009-01-23 01:48:47 +00:00
Jim Meyering
d0eab955c2
xm_internal.c: fix locking bug: s/Lock/Unlock/
...
* src/xm_internal.c (xenXMDomainDefineXML): Release lock, (don't
try to acquire it) upon failure, just before returning.
2009-01-22 19:18:24 +00:00
John Levon
fb4ec82358
Support script for bridge interface type
2009-01-22 18:29:13 +00:00
Daniel P. Berrange
e52d74e536
Make xen driver threadsafe
2009-01-21 18:11:14 +00:00
Daniel P. Berrange
84ef468ba8
Fix some misleading comments in XM driver
2009-01-20 18:20:09 +00:00
Daniel P. Berrange
788bedd904
Remove use of static data in Xen XM driver
2009-01-20 17:34:56 +00:00
Daniel P. Berrange
437ac354fc
Make error reporting threadsafe by avoiding strerror
2009-01-20 17:13:33 +00:00
Daniel Veillard
b751b46bc5
Fix PVFB version check for RHEL-5
...
* src/xend_internal.c src/xm_internal.c: fix paravirt framebuffer
handling since it was backoprted for RHEL-5, patch by Markus
Armbruster
daniel
2009-01-19 19:49:30 +00:00
Daniel Veillard
e676a699e8
* src/xend_internal.c src/xm_internal.c: fix fully virt network
...
device configuration for Xen on RHEL-5, patch by Markus Armbruster
daniel
2009-01-19 18:12:00 +00:00
Daniel Veillard
99ed5b4bee
Two bug fixes coming from RHEL and Markus being added to AUTHORS
...
* src/xm_internal.c: two bug fixes coming from RHEL package
posted by Markus Armbruster
* AUTHORS: adding Markus
daniel
2009-01-19 15:24:41 +00:00
Guido Günther
d6bd288da2
add missing flags argument
2009-01-08 19:52:15 +00:00
Guido Günther
043d702f02
use virAsprintf instead of asprintf
2008-12-23 13:03:29 +00:00
Daniel P. Berrange
e5fc0aad31
Fix return type for Xen open subdriver method impl (John Levon)
2008-12-17 21:26:16 +00:00
Daniel P. Berrange
319b83fc28
Fix XM driver handling of disk source paths
2008-11-28 11:23:34 +00:00
Daniel P. Berrange
5a01629128
Add missing translations
2008-11-25 11:18:08 +00:00
Daniel P. Berrange
8f7e086f19
Implement autostart for XM driver
2008-11-25 11:04:34 +00:00
Daniel P. Berrange
1eeceaa649
Support domain lifecycle events for Xen (Ben Guthro & Daniel Berrange)
2008-11-25 10:44:52 +00:00
Daniel P. Berrange
618276de19
Push URI probing logic down into individual drivers
2008-11-17 11:44:51 +00:00
Daniel P. Berrange
6ace5a39c3
Move some API declarations out of internal.h & hash.c into dedicated files
2008-11-04 23:22:06 +00:00
Daniel P. Berrange
d714b2afae
Move internal error APIs into virterror_internal.h & drop leading __ prefix
2008-11-04 22:30:33 +00:00
Daniel Veillard
ba2dff372c
* src/xm_internal.c: add minimum domain memory size check for Xen
...
patch by Shigeki Sakamoto
* AUTHORS: add Shigeki Sakamoto
Daniel
2008-10-31 13:06:17 +00:00
Daniel P. Berrange
bdd50bc7f3
Centralize domain mac address handling in domain_conf.c/util.c
2008-10-24 11:20:08 +00:00
Jim Meyering
fd52c6ff67
avoid many format string warnings
...
Building with --disable-nls exposed many new warnings like these:
virsh.c:4952: warning: format not a string literal and no format ...
util.c:163: warning: format not a string literal and no format arguments
All but one of the following changes add a "%s" argument before
the offending _(...) argument.
This was the only manual change:
* src/lxc_driver.c (lxcVersion): Use %s and strerror(errno)
rather than %m, to avoid a warning from gcc -Wformat-security.
Add "%s" before each warned about format-string-with-no-%-directive:
* src/domain_conf.c (virDomainHostdevSubsysUsbDefParseXML)
(virDomainDefParseString, virDomainDefParseFile):
* src/hash.c (virGetConnect, __virGetDomain, virReleaseDomain)
(__virGetNetwork, virReleaseNetwork, __virGetStoragePool)
(virReleaseStoragePool, __virGetStorageVol, virReleaseStorageVol):
* src/lxc_container.c (lxcContainerChild):
* src/lxc_driver.c (lxcDomainDefine, lxcDomainUndefine)
(lxcDomainGetInfo, lxcGetOSType, lxcDomainDumpXML)
(lxcSetupInterfaces, lxcDomainStart, lxcDomainCreateAndStart)
(lxcVersion, lxcGetSchedulerParameters):
* src/network_conf.c (virNetworkDefParseString)
(virNetworkDefParseFile):
* src/openvz_conf.c (openvzReadNetworkConf, openvzLoadDomains):
* src/openvz_driver.c (openvzDomainDefineCmd)
(openvzDomainGetInfo, openvzDomainDumpXML, openvzDomainShutdown)
(openvzDomainReboot, ADD_ARG_LIT, openvzDomainDefineXML)
(openvzDomainCreateXML, openvzDomainCreate, openvzDomainUndefine)
(openvzDomainSetAutostart, openvzDomainGetAutostart)
(openvzDomainSetVcpus):
* src/qemu_driver.c (qemudDomainBlockPeek, qemudDomainMemoryPeek):
* src/remote_internal.c (remoteDomainBlockPeek)
(remoteDomainMemoryPeek, remoteAuthPolkit):
* src/sexpr.c (sexpr_new, _string2sexpr):
* src/storage_backend_disk.c (virStorageBackendDiskMakeDataVol)
(virStorageBackendDiskCreateVol):
* src/storage_backend_fs.c
(virStorageBackendFileSystemNetFindPoolSources):
* src/storage_backend_logical.c (virStorageBackendLogicalFindLVs)
(virStorageBackendLogicalFindPoolSources):
* src/test.c (testOpenDefault, testOpenFromFile, testOpen)
(testGetDomainInfo, testDomainRestore)
(testNodeGetCellsFreeMemory):
* src/util.c (virExec):
* src/virsh.c (cmdAttachDevice, cmdDetachDevice)
(cmdAttachInterface, cmdDetachInterface, cmdAttachDisk)
(cmdDetachDisk, cmdEdit):
* src/xend_internal.c (do_connect, wr_sync, xend_op_ext)
(urlencode, xenDaemonDomainCreateXML)
(xenDaemonDomainLookupByName_ids, xenDaemonDomainLookupByID)
(xenDaemonParseSxprOS, xend_parse_sexp_desc_char)
(xenDaemonParseSxprChar, xenDaemonParseSxprDisks)
(xenDaemonParseSxpr, sexpr_to_xend_topology, sexpr_to_domain)
(xenDaemonDomainFetch, xenDaemonDomainGetAutostart)
(xenDaemonDomainSetAutostart, xenDaemonDomainMigratePerform)
(xenDaemonDomainDefineXML, xenDaemonGetSchedulerType)
(xenDaemonGetSchedulerParameters)
(xenDaemonSetSchedulerParameters, xenDaemonDomainBlockPeek)
(xenDaemonFormatSxprChr, virDomainXMLDevID):
* src/xm_internal.c (xenXMConfigCacheRefresh, xenXMDomainPinVcpu)
(xenXMDomainCreate, xenXMDomainDefineXML)
(xenXMDomainAttachDevice, xenXMDomainDetachDevice):
* src/xml.c (virXPathString, virXPathNumber, virXPathLong)
(virXPathULong, virXPathBoolean, virXPathNode, virXPathNodeSet):
* src/xs_internal.c (xenStoreOpen):
2008-10-13 16:46:28 +00:00
Daniel P. Berrange
427f7a8b09
Switch domain device objects to array instead of linked list
2008-10-10 16:08:01 +00:00
Daniel Veillard
f6803c960f
virDomainDefineXML, and a few additional cleanups
...
* include/libvirt/libvirt.h[.in] include/libvirt/virterror.h
qemud/remote* src/driver.h src/libvirt.c src/libvirt_sym.version
src/lxc_driver.c src/openvz_driver.c src/proxy_internal.c
src/qemu_driver.c src/remote_internal.c src/test.c src/virsh.c
src/xen_internal.c src/xen_unified.c src/xen_unified.h
src/xend_internal.c src/xend_internal.h src/xm_internal.c
src/xs_internal.c docs/*: cleanup virDomainCreateLinux into
virDomainDefineXML, and a few additional cleanups
Daniel
2008-10-10 09:32:27 +00:00
Cole Robinson
02fc93d624
Centralize majority of error reporting logic.
2008-10-09 15:38:31 +00:00
Daniel P. Berrange
126d3ebeea
Fix starting of xen domains without a PVFB console by removing default emulator
2008-09-05 11:52:12 +00:00
Daniel P. Berrange
bb16f4a25d
Do conditional driver config in Makefile.am, not source files
2008-08-20 20:48:35 +00:00
Daniel P. Berrange
cb29913fb1
Switch XM config file driver to use new domain APIs for XML to config conversion
2008-07-25 14:10:49 +00:00
Daniel P. Berrange
547bd71a4a
Switch XM config file driver to use new domain APIs for XML generation
2008-07-25 13:50:08 +00:00
Daniel P. Berrange
225fb3e93c
Prepare xm_internal driver for new domain XML apis
2008-07-25 13:39:02 +00:00
Daniel P. Berrange
8c6f5a546b
Convert XenD XML->SEXPR conversion to new domain XML APIs
2008-07-25 13:17:27 +00:00