Pavel Hrdina
8f827f2ace
qemu: skip only ',' for VNC and Spice unix socket
...
Commit 824272cb28
attempted to fix escaping of characters in unix
socket path but it was wrong. We need to escape only ',', there is
no escape character for '='.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
2017-06-12 12:45:25 +02:00
Pavel Hrdina
e6e26a899d
tests: unify qemu binary paths for all qemu related tests
...
Our test data used a lot of different qemu binary paths and some
of them were based on downstream systems.
Note that there is one file where I had to add "accel=kvm" because
the qemuargv2xml code parses "/usr/bin/kvm" as virt type="kvm".
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-04-11 14:06:47 +02:00
Pavel Hrdina
824272cb28
qemu: properly escape socket path for graphics
...
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1352529
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-02-24 12:58:51 +01:00
Ján Tomko
4808ebdef6
test-wrap-argv: set cutoff at 78 characters
...
For every but the last argument, we also need space for a space
and a backslash.
Rewrap everything longer than 78 characters.
2016-07-12 12:35:41 +02:00
Peter Krempa
e114b09157
qemu: caps: Always assume QEMU_CAPS_SMP_TOPOLOGY
...
Support for SMP topology was added by qemu commit dc6b1c09849484fbbc50
prior to 0.12.0, our minimum supported qemu version.
$ git describe --tags dc6b1c09849484fbbc50803307e4c7a3d81eab62
v0.11.0-rc0-449-gdc6b1c0
$ git describe --tags --contains dc6b1c09849484fbbc50803307e4c7a3d81eab
v0.12.0-rc0~1477
2016-07-07 15:08:35 +02:00
Cole Robinson
e3a6859019
qemu: command: Use -name guest= if available
...
-name guest= is the explicit parameter for passing a VM name. Using
it is required to allow a VM with an '=' in the name
https://bugzilla.redhat.com/show_bug.cgi?id=1276485
2016-05-16 10:30:38 -04:00
Cole Robinson
7dbbc0ca07
qemu: command: escape commas in chardev socket path
...
After this, a default virt-manager VM will startup with a comma
in the VM name:
https://bugzilla.redhat.com/show_bug.cgi?id=639926
2016-05-16 10:30:38 -04:00
Cole Robinson
077ba95677
qemu: command: escape commas in VNC socket path
...
This path can be dependent on the VM libdir, which contains its name
2016-05-16 10:30:38 -04:00
Cole Robinson
3153ac08c9
qemu: command: escape commas in secret master path
...
Need to convert the local function to virBuffer usage, so we
can use qemuBufferEscapeComma
2016-05-16 10:30:38 -04:00
Cole Robinson
0f377eb1b0
qemu: command: escape commas in VM name
...
This isn't sufficient on its own, since the VM name is used for things
like monitor paths, which we don't escape yet
2016-05-16 10:30:38 -04:00