Daniel P. Berrange
f43e709842
Added convenience virsh command for creating pools/volumes without XML
2008-02-20 15:29:13 +00:00
Jim Meyering
e8ff93b4e6
Remove more useless if tests before "free"-like functions.
...
* build-aux/useless-if-before-free: Rename from ...
* build-aux/find-unnecessary-if-before-free: ... this. Remove file.
Also changed it so that new names are no longer hard-coded in the
script. Instead, they're supplied via options:
* Makefile.cfg (useless_free_options): Define.
Add xmlXPathFreeObject to the list of free-like functions it detects.
* Makefile.maint (sc_avoid_if_before_free): Reflect script renaming.
* .x-sc_avoid_if_before_free: Likewise.
* src/openvz_conf.c (openvzParseXML): Remove useless "if"-before-free.
* src/qemu_conf.c (qemudParseXML, qemudParseNetworkXML): Likewise.
* src/virsh.c (cmdVNCDisplay, cmdTTYConsole, cmdDetachInterface):
(cmdDetachDisk): Likewise.
* src/xm_internal.c (xenXMConfigSetIntFromXPath): Likewise.
(xenXMConfigSetStringFromXPath, xenXMParseXMLToConfig): Likewise.
(xenXMDomainAttachDevice, xenXMAttachDisk, xenXMAttachInterface):
(xenXMDomainDetachDevice): Likewise.
* src/xml.c (virXPathString): Likewise.
* tests/xmlrpctest.c (checkRequestValue): Likewise.
2008-02-07 16:49:29 +00:00
Jim Meyering
5419d0b44d
Fix new "make distcheck" failures.
...
* src/xml.c (virDomainParseXMLOSDescHVM): Mark a diagnostic.
2008-02-05 22:07:31 +00:00
Jim Meyering
e04912a9f0
Remove all trailing blanks; turn on the rule to detect them.
...
* Makefile.cfg (local-checks-to-skip): Remove sc_trailing_blank.
* .x-sc_trailing_blank: New file, to exempt the few binary files.
2008-02-05 19:27:37 +00:00
Daniel P. Berrange
e87e3f86bf
Added support for booting off kenrel+initrd with HVM guests
2008-02-05 16:21:25 +00:00
Jim Meyering
fb66d5ab92
Eliminate all uses of virBufferAdd with string literals.
...
* Makefile.maint (sc_prohibit_virBufferAdd_with_string_literal):
New rule.
* src/buf.h (virBufferAddLit): Define.
* src/conf.c (virConfSaveValue): Use virBufferAddLit, in place
of virBufferAdd everywhere possible.
(virConfSaveEntry): Likewise.
* src/qemu_conf.c (qemudGenerateXML, qemudGenerateNetworkXML): Likewise.
* src/qemu_driver.c (qemudGetFeatures, qemudGetCapabilities): Likewise.
* src/test.c (testDomainDumpXML, testNetworkDumpXML): Likewise.
* src/xen_internal.c (xenHypervisorMakeCapabilitiesXML): Likewise.
* src/xend_internal.c (xend_parse_sexp_desc_os): Likewise.
(xend_parse_sexp_desc, sexpr_to_xend_topology_xml): Likewise.
* src/xm_internal.c (xenXMDomainFormatXML, xenXMDomainPinVcpu): Likewise.
* src/xml.c (virSaveCpuSet, virParseXenCpuTopology): Likewise.
(virDomainParseXMLGraphicsDescImage): Likewise.
(virDomainParseXMLGraphicsDescVFB, virDomainParseXMLOSDescHVM): Likewise.
(virDomainParseXMLOSDescPV, virDomainParseXMLDiskDesc): Likewise.
(virDomainParseXMLIfDesc, virDomainParseXMLDesc): Likewise.
2008-02-05 14:22:28 +00:00
Jim Meyering
ecaa696250
Enable more checks for unmarked messages; fix violators.
...
* Makefile.maint (sc_unmarked_diagnostics): Check for more functions.
* src/conf.c (virConfParseValue): Remove trailing space in diagnostic.
* src/libvirt.c (do_open, virDomainMigrate): Mark diagnostics.
* src/xend_internal.c (do_connect, xenDaemonDomainDumpXMLByID): Likewise.
(xenDaemonDomainDumpXMLByName, xenDaemonCreateLinux): Likewise.
(xenDaemonDomainMigratePerform, xenDaemonDomainDefineXML): Likewise.
* src/xml.c (virXPathString, virXPathNumber, virXPathLong): Likewise.
(virXPathBoolean, virXPathNode, virXPathNodeSet): Likewise.
(virDomainParseXMLOSDescHVM): Likewise.
* src/xmlrpc.c (xmlRpcValueNew): Likewise.
(xmlRpcValueUnmarshalDictElement): Likewise.
2008-02-04 19:31:30 +00:00
Jim Meyering
2367caa327
Also detect and remove unnecessary if-before-xmlXPathFreeContext.
...
* build-aux/find-unnecessary-if-before-free: Update regexp.
* src/openvz_conf.c: Remove unnecessary "if (P)"-before xmlXPathFreeContext.
* src/qemu_conf.c: Likewise.
* src/virsh.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* tests/xmlrpctest.c: Likewise.
2008-01-29 18:23:43 +00:00
Jim Meyering
a378188194
Enable the <config.h>-requiring test; fix violations
...
Use <config.h>, not "config.h", per autoconf documentation.
* Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
* .x-sc_require_config_h: New file, to list exempted files.
* Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
2008-01-29 18:15:54 +00:00
Jim Meyering
acff2d11ac
Given code like if (foo) free (foo); remove the useless "if (foo) " part.
...
Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
* proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
* python/generator.py: Likewise.
* qemud/qemud.c: Likewise.
* src/buf.c: Likewise.
* src/conf.c: Likewise.
* src/hash.c: Likewise.
* src/iptables.c: Likewise.
* src/libvirt.c: Likewise.
* src/openvz_conf.c: Likewise.
* src/qemu_conf.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/remote_internal.c: Likewise.
* src/test.c: Likewise.
* src/virsh.c: Likewise.
* src/virterror.c: Likewise.
* src/xen_internal.c: Likewise.
* src/xen_unified.c: Likewise.
* src/xend_internal.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* src/xmlrpc.c: Likewise.
* src/xs_internal.c: Likewise.
* tests/testutils.c: Likewise.
* tests/xencapstest.c: Likewise.
* tests/xmconfigtest.c: Likewise.
2008-01-29 17:41:07 +00:00
Jim Meyering
49230350fa
Use a variable name as sizeof argument, not a type name.
...
Given code like: T *var = calloc (n, sizeof (T));
Convert to this: T *var = calloc (n, sizeof (*var));
This first-cut change adjusts all malloc, calloc, and
realloc statements.
The only binary differences are in remote_internal.c
(due to the bug fix) and in xmlrpc.c (due to factorization).
* python/libvir.c: As above.
* qemud/event.c: Likewise.
* qemud/mdns.c: Likewise.
* qemud/qemud.c: Likewise.
* qemud/remote.c: Likewise.
* src/bridge.c: Likewise.
* src/buf.c: Likewise.
* src/conf.c: Likewise.
* src/hash.c: Likewise.
* src/iptables.c: Likewise.
* src/openvz_conf.c: Likewise.
* src/qemu_conf.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/test.c: Likewise.
* src/xen_internal.c: Likewise.
* src/xen_unified.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* tests/qemuxml2argvtest.c: Likewise.
* src/xmlrpc.c (xmlRpcValuePtr): Likewise, and minor factorization.
* src/remote_internal.c (remoteAuthMakeCredentials): Use the right
type when allocating space for an array of cred _pointers_.
2007-12-11 21:57:29 +00:00
Daniel P. Berrange
6d3f1d516e
Disable Xen specific functions if Xen driver is disabled
2007-11-30 22:51:54 +00:00
Richard W.M. Jones
46fdd02c75
Mon Nov 26 11:39:59 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in, src/internal.h, src/xml.c: <sys/syslimits.h>
is needed on Cygwin to get PATH_MAX. HOST_NAME_MAX and
IF_NAMESIZE defined if not in header files.
2007-11-26 11:40:28 +00:00
Daniel Veillard
9899932303
* src/xml.c src/xs_internal.c src/xs_internal.h: applied patch
...
from Masayuki Sunou to fix xend errors when adding disk
devices, due to improper device id lookup.
Daniel
2007-11-06 11:49:01 +00:00
Daniel Veillard
028275d6da
* src/xml.c: patch from Beth Kon to fix a problem when the
...
cpuset parameter for numa uses cpu maxcpu-1
Daniel
2007-11-05 10:14:42 +00:00
Daniel Veillard
390cca8125
* proxy/libvirt_proxy.c src/proxy_internal.[ch] src/xen_internal.c
...
src/xen_unified.[ch] src/xend_internal.[ch] src/xml.[ch]: last
patch for the library NUMA support, allow to serialize CPU pinning
to domain configs (but won't work though proxy access), includes
many patches from Saori Fukuta.
Daniel
2007-10-31 09:39:13 +00:00
Daniel Veillard
2718513226
* src/xml.c: fix build when configured without Xen
...
Daniel
2007-10-26 13:41:18 +00:00
Daniel Veillard
211a20aefb
* src/xml.c: applied patch from Jim Meyering fixing parseNumber
...
to detect overflow, and also reindented the module.
Daniel
2007-10-24 14:22:25 +00:00
Daniel Veillard
14c5c70a78
* src/xml.c: fix the build of the proxy broken on previous commit
...
Daniel
2007-10-23 15:31:33 +00:00
Daniel Veillard
cfb192ad1e
* docs/format.html docs/libvir.html: documentation cleaups
...
from Jim Paris
Daniel
2007-10-22 20:28:55 +00:00
Daniel P. Berrange
b4fab30b89
Mark XML param for attach/detach APIs const
2007-10-15 21:38:56 +00:00
Daniel P. Berrange
bf70fe4883
Fix virtual networking XML -> XM config file conversion & a mem leak
2007-10-10 17:41:06 +00:00
Daniel P. Berrange
84b5415cbf
Allow empty bootloader tag
2007-09-29 18:31:05 +00:00
Richard W.M. Jones
cc82a93645
Wed Sep 12 16:35:00 BST 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/xend_internal.c, src/xml.c, src/xml.h: Properly check buffer
size in virDomainXMLDevID (Hugh Brock).
2007-09-12 15:41:51 +00:00
Daniel P. Berrange
46b433f069
Cleanup UUID apis & constants
2007-08-09 20:19:12 +00:00
Daniel Veillard
6253863e8f
* src/xml.c: changes from Masayuki Sunou to improve error reporting
...
on device XML errors.
Daniel
2007-08-02 10:47:38 +00:00
Daniel P. Berrange
94711ff791
Fixed memory leaks
2007-07-31 14:27:12 +00:00
Daniel P. Berrange
f029721d2b
Added support for input devices
2007-07-18 21:08:22 +00:00
Daniel P. Berrange
67c346b102
Added new <clock/> element in XML for choosing utc/localtime
2007-07-16 21:30:30 +00:00
Daniel Veillard
657b5eb50c
* src/xml.c: applied modified patch from Masayuki Sunou for
...
device hot plug description with a wrong root element.
Daniel
2007-07-13 12:26:11 +00:00
Daniel Veillard
5ced7bd1fc
* src/virterror.c src/xml.c include/libvirt/virterror.h:
...
patch from Masayuki Sunou to check Ethernet MAC addresses
in XML configs
* po/*: string update and merge
Daniel
2007-07-13 08:26:57 +00:00
Daniel Veillard
fdc36dcbe6
* src/xml.c: patch from Masayuki Sunou fixing leaks in
...
virDomainParseXMLDiskDesc
Daniel
2007-07-11 08:41:11 +00:00
Richard W.M. Jones
9cd405497f
Wed Jul 4 10:14:00 BST 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/conf.c, src/test.c, src/xen_internal.c: Readd checking
of errors from virBuffer functions.
* src/sexpr.c: Add comment about use of _GNU_SOURCE.
* src/virsh.c: Remove use of _GNU_SOURCE / isblank.
* src/xml.c, tests/Makefile.am: Minor cleanup.
2007-07-04 09:16:23 +00:00
Daniel P. Berrange
a78a6602df
Move QEMU driver into main libvirt.so and use single daemon for all drivers
2007-06-26 23:48:46 +00:00
Daniel P. Berrange
2f02d292da
Move virBuffer functions into src/buf.c,h
2007-06-26 22:33:22 +00:00
Daniel Veillard
a80faa4bf0
* src/xend_internal.c src/xm_internal.c src/xml.c: add support
...
for arguments to bootloader, patch from Hugh Brock
* tests/sexpr2xmltest.c tests/xml2sexprtest.c
tests/sexpr2xmldata/sexpr2xml-pv-bootloader.sexpr
tests/sexpr2xmldata/sexpr2xml-pv-bootloader.xml
tests/xml2sexprdata/xml2sexpr-pv-bootloader.sexpr
tests/xml2sexprdata/xml2sexpr-pv-bootloader.xml: add specific
regression tests
Daniel
2007-06-07 13:50:18 +00:00
Daniel Veillard
41402668f9
* src/xml.c: patch from Saori Fukuta to avoid (type ioemu)
...
on Xen-3.1 and HVM guests devices to avoid breaking paravirt
drivers there
Daniel
2007-06-06 14:39:04 +00:00
Daniel Veillard
c6e2ef60df
* src/xml.c: apply patch from Masayuki Sunou about an uninitialized
...
string when attaching a device
Daniel
2007-06-04 08:42:41 +00:00
Daniel Veillard
ae35e97ec8
* src/xml.c: added a comment about (type ioemu) not needed
...
for interfaces on xen 3.1 as pointed by Saori Fukuta
Daniel
2007-06-01 14:03:24 +00:00
Daniel Veillard
b371d037b2
* src/internal.h src/xend_internal.c src/xml.c: applied 2 bug fixes
...
from Shigeki Sakamoto about large buffers.
Daniel
2007-04-23 07:41:23 +00:00
Daniel P. Berrange
42ee7111c3
Fixed up various functions for Xen 3.0.5
2007-04-13 00:43:57 +00:00
Daniel Veillard
1ec25df269
* src/xend_internal.c src/xml.c: applied patch from Nobuhiro Itou
...
to handle CDRom devices with no device name
* tests/sexpr2xmltest.c tests/xml2sexprtest.c
tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.sexpr
tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml
tests/xml2sexprdata/xml2sexpr-no-source-cdrom.sexpr
tests/xml2sexprdata/xml2sexpr-no-source-cdrom.xml: added regression
tests for this case based on Nobuhiro Itou test inputs.
Daniel
2007-04-11 16:06:30 +00:00
Daniel Veillard
73dd7f0ff5
* src/test.c: converted to new XPath APIs
...
* src/xml.c: fixed a return comment
Daniel
2007-04-06 15:34:09 +00:00
Daniel Veillard
4bdac20ad6
* src/xml.[ch]: first patch to clean up XPath accesses with new
...
routines, only xml.c is cleaned up, other modules to follow.
Daniel
2007-04-06 12:28:24 +00:00
Daniel Veillard
f2ffea858c
* qemud/buf.c src/xml.c: clarified virBufferGrow (and bufferGrow)
...
routines documentation and fixes a couple of places where this
was misused as pointed by Daniel Berrange.
Daniel
2007-03-21 15:24:56 +00:00
Daniel Veillard
9e170a88cd
* qemud/conf.c qemud/driver.h qemud/internal.h src/internal.h
...
src/sexpr.h src/test.c src/xm_internal.c src/xml.c src/xml.h:
applied patch from Richard Jones adding check to printf-like
functions and fixing the problems raised
Daniel
2007-03-16 15:03:21 +00:00
Daniel Veillard
d7e1c4fc51
* src/xml.c tests/sexpr2xmltest.c tests/xmconfigtest.c: avoid
...
warnings when compiling without Xen
Daniel
2007-03-16 14:55:51 +00:00
Daniel Veillard
181ce1fdc6
* configure.in proxy/Makefile.am proxy/libvirt_proxy.c
...
src/Makefile.am src/libvirt.c src/qemu_internal.c src/test.c
src/xen_internal.c src/xen_internal.h src/xend_internal.c
src/xm_internal.c src/xml.c src/xs_internal.c
tests/Makefile.am tests/sexpr2xmltest.c tests/xmconfigtest.c:
allow selective compilation of Xen,QEmu/KVM and test support
in or out at configure time. Also allows to compile on a system
without Xen development installed. All drivers are selected by
default.
Daniel
2007-03-15 07:43:16 +00:00
Daniel Veillard
6a1e3d5f36
* src/internal.h src/xend_internal.c src/xm_internal.c src/xml.c:
...
add a check for minimal size of Xen Dom0, track places where we
had arbitrary minimal memory requirement and use a predefined
macro to clean this up.
Daniel
2007-03-08 14:12:06 +00:00
Daniel Veillard
1e95c63059
* src/xml.c: applied patch from Nobuhiro Itou to allow the
...
VNC port 5900 to be used with xend, it's an edge case.
Daniel
2007-03-08 08:55:56 +00:00