56 Commits

Author	SHA1	Message	Date
Eric Blake	ddcfc5492a	alloc: make VIR_APPEND_ELEMENT safer ... VIR_APPEND_ELEMENT(array, size, elem) was not safe if the expression for 'size' had side effects. While no one in the current code base was trying to pass side effects, we might as well be robust and explicitly document our intentions. * src/util/viralloc.c (virInsertElementsN): Add special case. * src/util/viralloc.h (VIR_APPEND_ELEMENT): Use it. (VIR_ALLOC, VIR_ALLOC_N, VIR_REALLOC_N, VIR_EXPAND_N) (VIR_RESIZE_N, VIR_SHRINK_N, VIR_INSERT_ELEMENT) (VIR_DELETE_ELEMENT, VIR_ALLOC_VAR, VIR_FREE): Document which macros are safe in the presence of side effects. * docs/hacking.html.in: Document this. * HACKING: Regenerate. Signed-off-by: Eric Blake <eblake@redhat.com>	2013-05-07 13:21:31 -06:00
Michal Privoznik	70bc623b58	viralloc: Export virAllocTest* ... If users build with --enable-test-oom configure option, they get this error saying, virAllocTest* functions are not defined within tests/testutils.c.	2013-03-22 12:45:14 +01:00
Eric Blake	0df3e8966c	build: avoid shadowing a function name ... Make the same fix as in commit de53eff. * src/util/viralloc.h (virDeleteElementsN): Cater to old glibc.	2013-03-07 06:45:38 -07:00
Laine Stump	c720ddd6ac	util: fix typo in comment	2013-02-24 23:21:28 -05:00
John Ferlan	c9a85af319	viralloc: Adjust definition of VIR_FREE() for Coverity ... The Coverity static analyzer was generating many false positives for the unary operation inside the VIR_FREE() definition as it was trying to evaluate the else portion of the "?:" even though the if portion was (1). Signed-off-by: Eric Blake <eblake@redhat.com>	2013-01-22 10:19:43 -07:00
Daniel P. Berrange	ab9b7ec2f6	Rename memory.{c,h} to viralloc.{c,h}	2012-12-21 11:17:14 +00:00