Chris Lalancette
164f786626
Compiling with -Werror showed a possible use before initialization
...
in src/qemu_driver.c. Make sure to initialize the olddisk ptr to NULL.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-16 13:44:09 +00:00
Jim Meyering
fd52c6ff67
avoid many format string warnings
...
Building with --disable-nls exposed many new warnings like these:
virsh.c:4952: warning: format not a string literal and no format ...
util.c:163: warning: format not a string literal and no format arguments
All but one of the following changes add a "%s" argument before
the offending _(...) argument.
This was the only manual change:
* src/lxc_driver.c (lxcVersion): Use %s and strerror(errno)
rather than %m, to avoid a warning from gcc -Wformat-security.
Add "%s" before each warned about format-string-with-no-%-directive:
* src/domain_conf.c (virDomainHostdevSubsysUsbDefParseXML)
(virDomainDefParseString, virDomainDefParseFile):
* src/hash.c (virGetConnect, __virGetDomain, virReleaseDomain)
(__virGetNetwork, virReleaseNetwork, __virGetStoragePool)
(virReleaseStoragePool, __virGetStorageVol, virReleaseStorageVol):
* src/lxc_container.c (lxcContainerChild):
* src/lxc_driver.c (lxcDomainDefine, lxcDomainUndefine)
(lxcDomainGetInfo, lxcGetOSType, lxcDomainDumpXML)
(lxcSetupInterfaces, lxcDomainStart, lxcDomainCreateAndStart)
(lxcVersion, lxcGetSchedulerParameters):
* src/network_conf.c (virNetworkDefParseString)
(virNetworkDefParseFile):
* src/openvz_conf.c (openvzReadNetworkConf, openvzLoadDomains):
* src/openvz_driver.c (openvzDomainDefineCmd)
(openvzDomainGetInfo, openvzDomainDumpXML, openvzDomainShutdown)
(openvzDomainReboot, ADD_ARG_LIT, openvzDomainDefineXML)
(openvzDomainCreateXML, openvzDomainCreate, openvzDomainUndefine)
(openvzDomainSetAutostart, openvzDomainGetAutostart)
(openvzDomainSetVcpus):
* src/qemu_driver.c (qemudDomainBlockPeek, qemudDomainMemoryPeek):
* src/remote_internal.c (remoteDomainBlockPeek)
(remoteDomainMemoryPeek, remoteAuthPolkit):
* src/sexpr.c (sexpr_new, _string2sexpr):
* src/storage_backend_disk.c (virStorageBackendDiskMakeDataVol)
(virStorageBackendDiskCreateVol):
* src/storage_backend_fs.c
(virStorageBackendFileSystemNetFindPoolSources):
* src/storage_backend_logical.c (virStorageBackendLogicalFindLVs)
(virStorageBackendLogicalFindPoolSources):
* src/test.c (testOpenDefault, testOpenFromFile, testOpen)
(testGetDomainInfo, testDomainRestore)
(testNodeGetCellsFreeMemory):
* src/util.c (virExec):
* src/virsh.c (cmdAttachDevice, cmdDetachDevice)
(cmdAttachInterface, cmdDetachInterface, cmdAttachDisk)
(cmdDetachDisk, cmdEdit):
* src/xend_internal.c (do_connect, wr_sync, xend_op_ext)
(urlencode, xenDaemonDomainCreateXML)
(xenDaemonDomainLookupByName_ids, xenDaemonDomainLookupByID)
(xenDaemonParseSxprOS, xend_parse_sexp_desc_char)
(xenDaemonParseSxprChar, xenDaemonParseSxprDisks)
(xenDaemonParseSxpr, sexpr_to_xend_topology, sexpr_to_domain)
(xenDaemonDomainFetch, xenDaemonDomainGetAutostart)
(xenDaemonDomainSetAutostart, xenDaemonDomainMigratePerform)
(xenDaemonDomainDefineXML, xenDaemonGetSchedulerType)
(xenDaemonGetSchedulerParameters)
(xenDaemonSetSchedulerParameters, xenDaemonDomainBlockPeek)
(xenDaemonFormatSxprChr, virDomainXMLDevID):
* src/xm_internal.c (xenXMConfigCacheRefresh, xenXMDomainPinVcpu)
(xenXMDomainCreate, xenXMDomainDefineXML)
(xenXMDomainAttachDevice, xenXMDomainDetachDevice):
* src/xml.c (virXPathString, virXPathNumber, virXPathLong)
(virXPathULong, virXPathBoolean, virXPathNode, virXPathNodeSet):
* src/xs_internal.c (xenStoreOpen):
2008-10-13 16:46:28 +00:00
Daniel P. Berrange
7e0d3e62e9
Support SDL config with QEMU guests
2008-10-10 16:52:20 +00:00
Daniel P. Berrange
427f7a8b09
Switch domain device objects to array instead of linked list
2008-10-10 16:08:01 +00:00
Daniel P. Berrange
4789154063
Switch domain objects to array instead of linked list
2008-10-10 14:20:37 +00:00
Daniel P. Berrange
1564711a27
Split network driver out into separate files
2008-10-10 13:57:13 +00:00
Daniel Veillard
f6803c960f
virDomainDefineXML, and a few additional cleanups
...
* include/libvirt/libvirt.h[.in] include/libvirt/virterror.h
qemud/remote* src/driver.h src/libvirt.c src/libvirt_sym.version
src/lxc_driver.c src/openvz_driver.c src/proxy_internal.c
src/qemu_driver.c src/remote_internal.c src/test.c src/virsh.c
src/xen_internal.c src/xen_unified.c src/xen_unified.h
src/xend_internal.c src/xend_internal.h src/xm_internal.c
src/xs_internal.c docs/*: cleanup virDomainCreateLinux into
virDomainDefineXML, and a few additional cleanups
Daniel
2008-10-10 09:32:27 +00:00
Daniel Veillard
6d670a1fc1
use safewrite() and plug a leak
...
* src/cgroup.c: use safewrite()
* src/qemu_driver.c: missing VIR_FREE pojnted out by Eduardo Habkost
Daniel
2008-10-08 13:44:40 +00:00
Daniel Veillard
f9dbe46b44
* src/qemu_driver.c: another OOM handling cleanup (Guido Günther)
...
daniel
2008-10-07 16:39:32 +00:00
Daniel Veillard
9f4c047935
* src/qemu_driver.c: don't print and extra OOM error on top of getpwuid error
...
(Guido Günther)
Daniel
2008-10-07 16:01:23 +00:00
Daniel Veillard
72c40b0622
use C99 initializers for virState
...
* src/lxc_driver.c src/qemu_driver.c src/remote_internal.c
src/storage_driver.c: use C99 initializers for virState (Guido
Gunther)
Daniel
2008-10-06 15:40:37 +00:00
Cole Robinson
a166cdbb6e
Fix starting qemu VM with multiple pty char devices.
2008-10-02 14:10:20 +00:00
Daniel P. Berrange
0aac8c9447
Fix trailing whitespace & unmarked diagnostic warning
2008-09-18 08:54:23 +00:00
Richard W.M. Jones
dd57b821e4
Remove some deadcode (Nguyen Anh Quynh).
2008-09-17 14:21:27 +00:00
Richard W.M. Jones
04e9e1b2a6
configure.in, src/qemu_driver.h, src/qemu_driver.c: KVM
...
can determine max VCPUs at runtime (Guido Günther).
2008-09-17 14:07:49 +00:00
Daniel Veillard
58686c3dd8
add domain name in network configurations suport and on OpenVZ config bugfix
...
* src/network_conf.c src/network_conf.h src/qemu_driver.c: add
support for a domain name in network configurations, patch by
JJ Reynolds with bugfix raised by Dan
* src/openvz_conf.c: fix to small bug in openvzReadConfigParam
by Evgeniy Sokolov
Daniel
2008-09-08 12:45:29 +00:00
Daniel P. Berrange
126d3ebeea
Fix starting of xen domains without a PVFB console by removing default emulator
2008-09-05 11:52:12 +00:00
Daniel Veillard
a8d0600762
* src/qemu_driver.c: fix an error message, patch by Nguyen Anh Quynh
...
Daniel
2008-09-04 13:20:28 +00:00
Daniel Veillard
821dcf0ff7
* src/qemu_driver.c: switch flags to unsigned by James Morris
...
* AUTHORS: add James Morris
Daniel
2008-09-04 08:15:05 +00:00
Cole Robinson
e0b4fcc280
Fix qemu media connect/eject to work with latest syntax. Add support for ejecting floppy devices and scsi cdroms.
2008-09-03 16:05:25 +00:00
Cole Robinson
fe7bb57a8b
Update domain xml after usb device hotplug.
2008-09-03 15:05:31 +00:00
Cole Robinson
f4af06d812
Scrap media eject output to try and determine success/fail.
2008-09-03 14:43:34 +00:00
Daniel Veillard
53738f83a5
avoid a segfault on CD eject in KVM/QEmu
...
* src/qemu_driver.c: patch from Cole Robinson to avoid a segfault
on KVM CD eject
Daniel
2008-09-03 12:52:27 +00:00
Daniel P. Berrange
3348a97bd3
Switch over fork/exec code to use virExec
2008-08-29 07:11:15 +00:00
Daniel P. Berrange
da1963381b
Fix QEMU domain creation by allowing virExec to preserve certain FDs
2008-08-27 11:42:52 +00:00
Daniel P. Berrange
bb16f4a25d
Do conditional driver config in Makefile.am, not source files
2008-08-20 20:48:35 +00:00
Daniel P. Berrange
6334cd16df
Remove configFile/autostartLink vars from virDomainObj struct
2008-08-20 19:42:36 +00:00
Daniel Veillard
b73d495754
* src/network_conf.c src/network_conf.h src/qemu_driver.c: allow to
...
add static host definition for dnsmasq
Daniel
2008-08-20 12:50:29 +00:00
Daniel P. Berrange
1b4bb7d4ab
Allow non-blocking/daemon mode to be specified via virExec flags
2008-08-20 09:24:14 +00:00
Daniel P. Berrange
6bc99a7775
Allow a pre-opened FD to be be pass to virExec for stdout/err
2008-08-20 09:08:17 +00:00
Atsushi SAKAI
6fd4c30285
fix typos src/virsh.c from John Levon,
...
and 3 more files(src/domain_conf.c src/openvz_driver.c src/qemu_driver.c)
2008-08-15 01:41:49 +00:00
Atsushi SAKAI
413c5dbf07
add _fd to stdin, stderr stdout in struct virDomainObj for compilation on MinGW
2008-08-12 08:38:22 +00:00
Daniel P. Berrange
b3728d7d72
Fix const-correctness of virRUn and virExec
2008-08-08 15:43:38 +00:00
Daniel Veillard
5ba372306a
llow to add a disk as an USB device (QEmu/KVM)
...
* src/domain_conf.c src/domain_conf.h src/qemu_conf.c
src/qemu_driver.c: patch from Guido Günther allowing to add
disk as USB devices
* docs/libvirt.rng: extend the schemas for the new value
* tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args
tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml
tests/qemuxml2argvtest.c tests/qemuxml2xmltest.c: add a specific
test to the regression suite
Daniel
2008-08-08 15:03:00 +00:00
Daniel Veillard
d1710d35ea
Extend parser and add support for USB devices in QEmu/KVM
...
* src/domain_conf.c src/domain_conf.h src/qemu_conf.c
src/qemu_driver.c: Patch from Guido Günther allowing to pass
usb devices to qemu/kvm
* docs/libvirt.rng: add the new functionality to the grammar
* tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.args
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-product.args
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-product.xml
tests/qemuxml2argvtest.c tests/qemuxml2xmltest.c: adding examples
to the regression tests
* libvirt.spec.in: fix the licence tag
Daniel
2008-08-08 14:27:05 +00:00
Daniel P. Berrange
ffc839fb20
Always set forward-delay on bridge, even if 0
2008-08-01 12:56:52 +00:00
Daniel Veillard
c810c6cc23
* src/qemu_driver.c: patch from Chris Lalancette adding missing
...
carriage returns to logs
Daniel
2008-08-01 11:24:04 +00:00
Daniel Veillard
7711e6858c
* src/qemu_driver.c: apply patch from Charles Duffy fixing erro
...
messages when trying to crate a domain already defined.
Daniel
2008-08-01 06:23:31 +00:00
Daniel Veillard
55e1221686
* src/qemu_driver.c: patch from Guido Günther, interface stats should
...
not crash on interfaces without an ifname.
Daniel
2008-07-30 09:20:19 +00:00
Daniel Veillard
387e06421f
* src/qemu_driver.c: patch from Guido Günther to make sure create
...
doesn't override an existing domain definition or UUID
Daniel
2008-07-28 12:52:37 +00:00
Daniel P. Berrange
3de646a51d
Misc bug fixes
2008-07-25 09:31:24 +00:00
Daniel Veillard
c1e6cc1969
* src/qemu_driver.c: some uuid to string conversion were missing
...
patch from Guido Günther
Daniel
2008-07-25 09:01:25 +00:00
Daniel Veillard
6fae611381
wrong open() failure detection
...
* src/qemu_driver.c: Guido Trotter pointed out a wrong open() failure
detection
Daniel
2008-07-25 08:42:05 +00:00
Daniel Veillard
27efc8bd0d
Check for already running QEmu domain on create
...
* src/qemu_driver.c: another patch from Guido Günther checking
for an already running domain on create
Daniel
2008-07-24 07:29:50 +00:00
Daniel Veillard
d3bb1e4367
* src/qemu_driver.c: patch from Guido Günther checking for
...
unsupported migrate command
Daniel
2008-07-24 07:09:45 +00:00
Daniel P. Berrange
6385fe3ede
Switch QEMU driver over to generic domain APIs
2008-07-11 19:34:11 +00:00
Daniel P. Berrange
381fa1fc46
Switch QEMU driver over to generic network APIs
2008-07-11 17:33:45 +00:00
Daniel P. Berrange
1d86fca433
Fix parsing of QEMU stdout looking for serial device PTY with Xenner
2008-07-11 09:48:51 +00:00
Atsushi SAKAI
fbb5d771a0
Compilation fixes for MinGW
2008-06-26 09:37:51 +00:00
Daniel P. Berrange
db162cb2b8
Fix saving of iptables rules
2008-06-12 13:47:38 +00:00