External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-06 04:55:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
42,865 Commits 67 Branches 629 Tags 868 MiB
c40421f702
Commit Graph

42865 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kristina Hanicova
d91a3e96c0 storage: create logical volume with --yes option 
If lvcreate found an existing signature when trying to create a
new logical volume (E.g. left after some deleted volume), the
action failed due to inability to answer interactive question to
wiping it (lvcreate assumed 'no' was the answer). With added
option --yes to the command line, the answer to any interactive
question is assumed to be yes. Therefore, lvcreate wipes the
signature and the new volume is created successfully.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1940413

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2021-07-23 11:44:38 +02:00
Tim Wiederhake
7b8d4d99b5 virStorageVolObjListNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:32:12 +02:00
Tim Wiederhake
cc69362e36 virSecuritySELinuxQEMUInitialize: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:32:12 +02:00
Tim Wiederhake
50b068d239 virSecuritySELinuxLXCInitialize: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:32:12 +02:00
Tim Wiederhake
7e26e0c98e virQEMUCapsProbeQMPHostCPU: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:32:12 +02:00
Tim Wiederhake
3fab2688ac virNodeDeviceObjListNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:32:12 +02:00
Tim Wiederhake
4a40b9a4fd virNetworkObjNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:32:12 +02:00
Tim Wiederhake
5f4e80d174 virNetworkObjListNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:32:12 +02:00
Tim Wiederhake
45ccb05d24 virNetDaemonNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:32:12 +02:00
Tim Wiederhake
6555711d41 virLockSpaceNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:31:23 +02:00
Tim Wiederhake
cf46841d45 virLockDaemonNewPostExecRestart: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:31:20 +02:00
Tim Wiederhake
357e8c0210 virLockDaemonNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:31:18 +02:00
Tim Wiederhake
9143425098 virInterfaceObjListNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:31:15 +02:00
Tim Wiederhake
8b04af42da virHashAtomicNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:31:12 +02:00
Tim Wiederhake
d2a57b4d68 virFileCacheNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:31:09 +02:00
Tim Wiederhake
885ee2aa1f virDomainObjListNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:31:06 +02:00
Tim Wiederhake
bb3a57c8b0 virDomainMomentObjListNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:31:03 +02:00
Tim Wiederhake
cf1234abf1 virDomainDefValidateAliases: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:31:01 +02:00
Tim Wiederhake
c94a217e5c virDomainDefBootOrderPostParse: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:57 +02:00
Tim Wiederhake
f6252cf6b0 virDomainCCWAddressSetCreate: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:55 +02:00
Tim Wiederhake
1670b9116a virCloseCallbacksNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:52 +02:00
Tim Wiederhake
cb7260c7d8 virChrdevAlloc: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:49 +02:00
Tim Wiederhake
d79a5e4e1b qemuInteropFetchConfigs: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:46 +02:00
Tim Wiederhake
ecb5dd2a9b qemuDomainObjPrivateAlloc: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:43 +02:00
Tim Wiederhake
4bfc24fb87 qemuBlockNodeNameGetBackingChain: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:40 +02:00
Tim Wiederhake
26c09438e2 qemuBlockNodeNamesDetect: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:38 +02:00
Tim Wiederhake
ae06bc9cfe libxlLoggerNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:34 +02:00
Tim Wiederhake
3ae0c7715e qemusecuritymock: init_hash: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:31 +02:00
Tim Wiederhake
69e2426b83 hypervCreateEmbeddedParam: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:28 +02:00
Tim Wiederhake
cc93d2e3f1 ebiptablesApplyNewRules: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:26 +02:00
Tim Wiederhake
8bccb3b40c virNWFilterRuleDefToRuleInst: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:23 +02:00
Tim Wiederhake
953c7e024a virNWFilterCreateVarsFrom: Remove superfluous gotos 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:20 +02:00
Tim Wiederhake
a63665c041 virNWFilterCreateVarsFrom: Use automatic memory management 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:17 +02:00
Tim Wiederhake
a6853d691b virNWFilterCreateVarsFrom: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:14 +02:00
Tim Wiederhake
3b559a7778 virSystemdActivationNew: Remove superfluous gotos 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:11 +02:00
Tim Wiederhake
8b565bf40b virSystemdActivationNew: Use automatic memory management 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:30:08 +02:00
Tim Wiederhake
45c3845150 virSystemdActivationNew: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
 2021-07-23 11:29:57 +02:00
Tim Wiederhake
c7560d0141 virNWFilterLearnInit: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Tim Wiederhake
4d9c5524b4 virNWFilterIPAddrMapInit: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Tim Wiederhake
e96575f314 virNWFilterDoInstantiate: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Tim Wiederhake
7520984c1c virNWFilterParseParamAttributes: Remove superfluous gotos 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Tim Wiederhake
8ca6d834ad virNWFilterParseParamAttributes: Simplify loop body 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Tim Wiederhake
84ac5beeac virNWFilterParseParamAttributes: Use automatic memory management 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Tim Wiederhake
ec5838fc17 virNWFilterParseParamAttributes: Remove tautological if 
`cur` is guaranteed to be of type `XML_ELEMENT_NODE` by using
`xmlFirstElementChild()` and `xmlNextElementSibling()`.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Tim Wiederhake
71a2cdb8ec virNWFilterParseParamAttributes: Iterate over "element" children 
"xmlNextElementSibling()" skips attribute nodes, making the explicit
check for the type of `cur` redundant. This prepares for the removal
of this check in the next commit.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Tim Wiederhake
e18d41444e virNWFilterParseParamAttributes: virHashNew cannot return NULL 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Tim Wiederhake
8de3bb0f58 conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue 
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 11:27:05 +02:00
Pavel Hrdina
dc721f99df virsh: fix setmem flags logic 
When we dropped virDomainSetMemory usage it got kind of tricky to
figure out the flags correctly.

Originally the logic was following:

    no option | --current | --live | --config | --live --config
    ----------+-----------+--------+----------+----------------
       LIVE   |  CURRENT  |  LIVE  |  CONFIG  |  LIVE & CONFIG

But after the commit removing virDomainSetMemory usage it changed to:

    no option | --current | --live |    --config     | --live --config
    ----------+-----------+--------+-----------------+----------------
       LIVE   |  CURRENT  |  LIVE  |  LIVE & CONFIG  |  LIVE & CONFIG

This commit fixes the logic back to the original behavior except for
ESX, HyperV and Virtuozzo drivers where virDomainSetMemory() default
behavior was CURRENT instead of LIVE.

Fixes: ce8138564b
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1980199
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2021-07-23 11:24:51 +02:00
Justin Gatzen
e7d579a2dd conf: Add grabToggle to evdev input 
Add support for customizable grabToggle key combinations with
<input type='evdev'>.

Signed-off-by: Justin Gatzen <justin.gatzen@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
 2021-07-23 11:20:48 +02:00
Peter Krempa
e286a62941 qemu: process: Extract code for submitting event handling to separate thread 
The submission of the event to the helper thread has a verbose cleanup
path which was duplicated in all the event handlers. Simplify it by
extracting the code into a helper named 'qemuProcessEventSubmit' and
reuse it where appropriate.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
 2021-07-23 10:01:48 +02:00